2025-04-22 06:24:48Samuli Seppänen:
Add missing "not" into Gerrit documentation
Development/DeveloperDocumentation.md ..
@@ 160,7 160,7 @@
The use of Gerrit is encouraged over using [GitHub Pull-Requests](https://github.com/OpenVPN/openvpn/pulls). The main difference is that our development workflow is currently patch orientated. Even when you submit a patch series, each patch needs to stand on its own, and produce a working build. Each patch will be merged individually. Gerrit supports this model, while Pull Requests like in !GitHub or similar products are more branch-oriented.
-
Note that we currently do directly merge the patches via the Gerrit tool. Instead they are still submitted to the mailing list for the final step of the workflow as described above. We have written a small script that facilitates sending a patch reviewed through Gerrit to the list. You can find [gerrit-send-mail.py](https://github.com/OpenVPN/openvpn/blob/master/dev-tools/gerrit-send-mail.py) in the `dev-tools` directory in the Git repository. That script will take care of adding *Acked-By* lines automatically based on the Gerrit reviews. Anyone can submit a patch to the mailing list once it is reviewed and approved. But of course we encourage the patch author to take care of it themselves.
+
Note that we currently do not directly merge the patches via the Gerrit tool. Instead they are still submitted to the mailing list for the final step of the workflow as described above. We have written a small script that facilitates sending a patch reviewed through Gerrit to the list. You can find [gerrit-send-mail.py](https://github.com/OpenVPN/openvpn/blob/master/dev-tools/gerrit-send-mail.py) in the `dev-tools` directory in the Git repository. That script will take care of adding *Acked-By* lines automatically based on the Gerrit reviews. Anyone can submit a patch to the mailing list once it is reviewed and approved. But of course we encourage the patch author to take care of it themselves.
For more information and tips about using Gerrit see [GerritBestPractises](../Development/GerritBestPractices).
