Opened 15 months ago

Last modified 3 months ago

#1327 new Feature Wish

revisit msg() messagelevels, go away from "M_INFO for everything"

Reported by: Gert Döring Owned by:
Priority: major Milestone: release 2.6
Component: Generic / unclassified Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords: logging, msg, M_INFO
Cc: Selva Nair, stipa, tct

Description

errlevel.h has a nice collection of D_ flags for "log this only for --verb 3 or higher, and rate-limit" etc. (D_IFCONFIG_POOL()) - so stuff like pool.c shouldn't do

            msg(M_INFO, "ifconfig_pool_read(), in='%s'", BSTR(&in));

for "we read this lengthy file, here's line-by-line output" - M_INFO is "1", so nearly always printed...

But we have very many of these, so

  • come to agreement what we want to use
  • document this
  • go through the files one-by-one and use "the right" code

Change History (4)

comment:1 Changed 15 months ago by Gert Döring

Cc: Selva Nair stipa added

comment:2 Changed 15 months ago by Gert Döring

Cc: tct added

comment:3 Changed 5 months ago by tct

The grasp exceeds the reach ..

comment:4 Changed 3 months ago by tct

peer info: * probably doesn't need to be --verb 1

Note: See TracTickets for help on using tickets.