Opened 14 years ago
Closed 14 years ago
#5 closed Bug / Defect (fixed)
Fix OpenSSL-1.0.0 compilation warnings
| Reported by: | David Sommerseth | Owned by: | Emmanuel Bretelle |
|---|---|---|---|
| Priority: | major | Milestone: | beta 2.2 |
| Component: | Building / Compiling | Version: | OpenVPN git master branch (Community Ed) |
| Severity: | Patch Queue: Awaiting testing before ACK | Keywords: | |
| Cc: |
Description (last modified by )
Compiled the master branch from openvpn-testing.git on Fedora 12, and
noticed these warnings:
ssl.c: In function ‘verify_callback’:
ssl.c:944: warning: passing argument 1 of ‘sk_num’ from incompatible
pointer type
/usr/include/openssl/stack.h:79: note: expected ‘const struct _STACK *’
but argument is of type ‘struct stack_st_X509_REVOKED *’
ssl.c:947: warning: passing argument 1 of ‘sk_value’ from incompatible
pointer type
/usr/include/openssl/stack.h:80: note: expected ‘const struct _STACK *’
but argument is of type ‘struct stack_st_X509_REVOKED *’
ssl.c: In function ‘init_ssl’:
ssl.c:1565: warning: passing argument 1 of ‘sk_num’ from incompatible
pointer type
/usr/include/openssl/stack.h:79: note: expected ‘const struct _STACK *’
but argument is of type ‘struct stack_st_X509 *’
ssl.c: In function ‘print_details’:
ssl.c:1766: warning: assignment discards qualifiers from pointer target type
$ rpm -q openssl openssl-devel
openssl-1.0.0-0.13.beta4.fc12.x86_64
openssl-devel-1.0.0-0.13.beta4.fc12.x86_64
Attachments (2)
Change History (8)
comment:1 Changed 14 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | → beta 2.2 |
comment:2 Changed 14 years ago by
| Owner: | set to David Sommerseth |
|---|---|
| Status: | new → accepted |
Changed 14 years ago by
| Attachment: | 0001-Fixes-openssl-1.0.0-compilation-warning.patch.gz added |
|---|
comment:3 Changed 14 years ago by
Changed 14 years ago by
| Attachment: | 0001-Fixes-openssl-1.0.0-compilation-warning.patch added |
|---|
same patch viewable online
comment:4 Changed 14 years ago by
| Owner: | changed from David Sommerseth to Emmanuel Bretelle |
|---|---|
| Severity: | Not set (if unsure, select this one) → Patch Queue: Awaiting testing before ACK |
| Status: | accepted → assigned |
comment:5 Changed 14 years ago by
Thanks a lot! I've tested compiling this patch on an older
openssl-0.9.8e and openssl-1.0.0a. I've tested the patch with
openssl-1.0.0a running openvpn as a client as well.
I'll do some more testing on this patch, with openssl-0.9.8e both as a
server and client. If that looks good, you'll get an ACK :)
Thanks again for great work!
comment:6 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Applied to the bugfix2.1 branch.
commit db3fb3d489df234c78ddcb9fce66de4d8fbb28e6
Author: chantra <chantra@…>
Date: Fri Jul 16 20:09:07 2010 +0200
Fixes openssl-1.0.0 compilation warning
When compiling against OpenSSL v1.0.0, the following compiler warnings
appears.
ssl.c: In function ‘verify_callback’:
ssl.c:944: warning: passing argument 1 of ‘sk_num’ from incompatible
pointer type
/usr/include/openssl/stack.h:79: note: expected ‘const struct _STACK *’
but argument is of type ‘struct stack_st_X509_REVOKED *’
ssl.c:947: warning: passing argument 1 of ‘sk_value’ from incompatible
pointer type
/usr/include/openssl/stack.h:80: note: expected ‘const struct _STACK *’
but argument is of type ‘struct stack_st_X509_REVOKED *’
ssl.c: In function ‘init_ssl’:
ssl.c:1565: warning: passing argument 1 of ‘sk_num’ from incompatible
pointer type
/usr/include/openssl/stack.h:79: note: expected ‘const struct _STACK *’
but argument is of type ‘struct stack_st_X509 *’
ssl.c: In function ‘print_details’:
ssl.c:1766: warning: assignment discards qualifiers from pointer target type
Trac ticket #5
https://community.openvpn.net/openvpn/ticket/5
Signed-off-by: chantra <chantra@…>
Acked-by: David Sommerseth <dazo@…>
Signed-off-by: David Sommerseth <dazo@…>
Hopefully attachment:0001-Fixes-openssl-1.0.0-compilation-warning.patch.gz will solves it.
I could compile openvpn correctly using openssl-1.0.0a and 0.9.8k-7ubuntu8