Opened 8 years ago

Closed 4 years ago

#234 closed Bug / Defect (fixed)

Clean up hard-coded paths in win32.c:configure_win_path()

Reported by: David Sommerseth Owned by:
Priority: trivial Milestone: release 2.4
Component: plug-ins / plug-in API Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords: windows path
Cc: Heiko Hund

Description

This functions have a hard coded path to route.exe. Review this function and consider if this is needed on newer Windows releases (WinXP or newer) and see if this can be solved better without hard-coding C:\Windows in the path.

See trac ticket #106 for a little bit more info.

Change History (4)

comment:1 Changed 7 years ago by Gert Döring

Cc: Heiko Hund added
Milestone: release 2.4

So... anyone working on it?

I think we won't fix it for 2.3.3, and for 2.4, we'll use the interactive service, so it might become irrelevant then. Copying d12fk and setting 2.4 milestone.

comment:2 Changed 7 years ago by David Sommerseth

I believe this will be fixed indirectly when d12fk's new GUI comes in 2.4, as that will tackle route setups in a completely different way than calling route.exe explicitly from openvpn.exe.

comment:3 Changed 4 years ago by selvanair

This was fixed here:

commit 7546cba4761b24f2195034dcd3407aecd43fd3be
Author: Selva Nair <selva.nair@…>
Date: Thu Nov 12 21:41:27 2015 -0500

Do not hard-code windows systemroot in env_block


FWIW, fixes trac #500


Signed-off-by: Selva Nair <selva.nair@…>
Acked-by: Gert Doering <gert@…>
Message-Id: <1447382487-26031-1-git-send-email-selva.nair@…>
URL: http://article.gmane.org/gmane.network.openvpn.devel/10492
Signed-off-by: Gert Doering <gert@…>

comment:4 Changed 4 years ago by David Sommerseth

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.