Opened 8 years ago

Closed 8 years ago

#220 closed Patch submission (wontfix)

Makefile.in does not use DESTDIR in install target tests

Reported by: James Smith Owned by:
Priority: trivial Milestone:
Component: Building / Compiling Version: OpenVPN 2.2.2 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description

When using DESTDIR=/myrootfs make install, there are some test commands that do not use DESTDIR even though they then work on DESTDIR.

See the attached patch- note I've only checked the root directory's Makefile.in.

I'm wondering if this comes from some upstream auto-generation tool because I've seen it in another (defunct) project too.

Attachments (1)

openvpn-destdir.diff (3.5 KB) - added by James Smith 8 years ago.
Makefile.in DESTDIR test patch

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by James Smith

Attachment: openvpn-destdir.diff added

Makefile.in DESTDIR test patch

comment:1 Changed 8 years ago by David Sommerseth

Resolution: wontfix
Status: newclosed

Thank you very much. The OpenVPN 2.2 base will not get any particular updates, unless critical bugs or security fixes are needed, that release base is in maintenance mode.

We have done a complete overhaul of the complete autotools build system in 2.3-alpha2 (released July 2) which should have fixed a lot of issues generally. I hope this is fixed there.

However, these tests shouldn't be an install target either. So I wouldn't expect it to care much about DESTDIR. And when testing this, it behaves as expected:

$ cd openvpn/tests
$ make install DESTDIR=/tmp/ovpn-test-inst
make[1]: Entering directory `/home/dazo/openvpn/tests'
make[1]: Nothing to be done for `install-exec-am'.
make[1]: Nothing to be done for `install-data-am'.
make[1]: Leaving directory `/home/dazo/openvpn/tests'
$

Closing as wontfix for now. If you feel different about it, please open a discussion on this topic on the openvpn-devel@… mailing list.

Note: See TracTickets for help on using tickets.