Opened 3 years ago

Last modified 3 years ago

#1396 assigned Bug / Defect

option restoration on SIGUSR1 is incomplete

Reported by: Gert Döring Owned by: plaisthos
Priority: minor Milestone: release 2.6
Component: Generic / unclassified Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:



during review/testing of commit 5a2ed714d14a and commit 7064ccb9f it was found that there are more options that need restoration on SIGUSR1:

compress lz4

(if connection A pushes them and B doesn't, and we change from A to B by means of a SIGUSR1 restart, the old values get stuck in the config).

There might be more, but this is the ticket to not forget.

Change History (3)

comment:1 Changed 3 years ago by Gert Döring

See #128 as well - this bug has been with us for a long time :-)

comment:2 Changed 3 years ago by Gert Döring

"compress" fixed in master

commit 2a414c3c79bba089183a517a2d355b5aaae0b4a4 (HEAD -> master)
Author: Arne Schwabe <arne@…>
Date: Thu Apr 8 14:00:28 2021 +0200

Also restore/save compress related options in reconnects

comment:3 Changed 3 years ago by Gert Döring

"route-gateway" and "route-ipv6-gateway" fixed in master+2.5

commit 57c8d220aab14b661bafd4fafc40c195326b8d8f (master)
commit 7b594d4980f696583397a3b87e5c928acba17081 (release/2.5)
Author: Arne Schwabe
Date: Fri Apr 16 15:35:12 2021 +0200

Also restore/save route-gateway options on SIGUSR1 reconnects

still open: compress for 2.5 (which needs more commits backported it seems)

Note: See TracTickets for help on using tickets.