mingw builds: version number missing in LZO DLL

[Gert Döring]

as discussed on the hackathon: something in our mingw builds of liblzo is missing the insertion of the version number (as a resource binary) into liblzo.dll.

It works for other stuff we build, so "how hard can it be" :-)

Assigning to Samuli so this is not lost.

[tct]

Test for #1238 -- Do you receive notification ?

[Gert Döring]

This is not critical, but it would be nice if it could be fixed...

@selva, do you have an idea how to tackle that?

[Selva Nair]

lzo-properties

[Selva Nair]

LZO source does not seem to come with a resource file. We can add one (with result as in the image below), but we'll have to maintain the patch. As lzo hardly gets any updates, it may not be a big burden, though.

[Gert Döring]

As @stipa does much of the heavy lifting of the windows releases right now, cc'ing

[Gert Döring]

So, how do we want to proceed here? Improve things (for 2.5.3 or 2.6) or "it's the way it is, compression will eventually go away anyway [in 2.8 or so], so close the ticket"?

[stipa]

I checked vcpkg lzo port and they (vcpkg port maintainers) also don't bother to set version with custom rc file, so let's leave it as it.

[Samuli Seppänen]

I say we just ignore this. At least not in our mingw buildsystem, as that's going away in favour of MSVC for the only builds we really care about, that is, Windows builds.

[Gert Döring]

I think we still want this, so maybe open a ticket against the vcpkg port to get a custom rc for MSVC builds?