Opened 23 months ago

Last modified 3 months ago

#1229 assigned Bug / Defect

mingw builds: version number missing in LZO DLL

Reported by: Gert Döring Owned by: Samuli Seppänen
Priority: minor Milestone: release 2.5.3
Component: Building / Compiling Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc: Selva Nair, stipa

Description

as discussed on the hackathon: something in our mingw builds of liblzo is missing the insertion of the version number (as a resource binary) into liblzo.dll.

It works for other stuff we build, so "how hard can it be" :-)

Assigning to Samuli so this is not lost.

Attachments (1)

lzo-details.png (23.7 KB) - added by Selva Nair 14 months ago.
lzo-properties

Download all attachments as: .zip

Change History (10)

comment:1 Changed 22 months ago by tct

Test for #1238 -- Do you receive notification ?

comment:2 Changed 14 months ago by Gert Döring

Cc: snair added

This is not critical, but it would be nice if it could be fixed...

@selva, do you have an idea how to tackle that?

comment:3 Changed 14 months ago by Gert Döring

Cc: Selva Nair added; snair removed

Changed 14 months ago by Selva Nair

Attachment: lzo-details.png added

lzo-properties

comment:4 Changed 14 months ago by Selva Nair

LZO source does not seem to come with a resource file. We can add one (with result as in the image below), but we'll have to maintain the patch. As lzo hardly gets any updates, it may not be a big burden, though.

lzo-properties

comment:5 Changed 12 months ago by Gert Döring

Cc: stipa added

As @stipa does much of the heavy lifting of the windows releases right now, cc'ing

comment:6 Changed 6 months ago by Gert Döring

Milestone: release 2.5release 2.5.3

So, how do we want to proceed here? Improve things (for 2.5.3 or 2.6) or "it's the way it is, compression will eventually go away anyway [in 2.8 or so], so close the ticket"?

comment:7 Changed 6 months ago by stipa

I checked vcpkg lzo port and they (vcpkg port maintainers) also don't bother to set version with custom rc file, so let's leave it as it.

comment:8 Changed 3 months ago by Samuli Seppänen

I say we just ignore this. At least not in our mingw buildsystem, as that's going away in favour of MSVC for the only builds we really care about, that is, Windows builds.

comment:9 Changed 3 months ago by Samuli Seppänen

Priority: majorminor
Note: See TracTickets for help on using tickets.