Opened 14 years ago

Closed 14 years ago

#99 closed Bug / Defect ( fixed )

Small fix for old GCC

Reported by: Simon Matter Owned by: David Sommerseth
Priority: minor Milestone: release 2.2.1
Component: Building / Compiling Version: OpenVPN 2.2-beta / 2.2-RC (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description

Old GCC doesn't like 2.2-RC. Attached patch fixes it.

Attachments (1)

openvpn-2.2-RC-oldgcc.patch ​ ( 749 bytes ) - added by Simon Matter 14 years ago .

.zip

Change History (3)

Changed 14 years ago by Simon Matter

Attachment: openvpn-2.2-RC-oldgcc.patch ​ added

comment:1 Changed 14 years ago by David Sommerseth

Keywords: GCC removed
Milestone: → release 2.2.1
Owner: set to David Sommerseth
Priority: major → minor
Status: new → accepted

comment:2 Changed 14 years ago by David Sommerseth

Resolution: → fixed
Status: accepted → closed

ACK.

Thanks a lot for the patch. I've applied the patch to the master branch and cherry-picked it for the next 2.2 release. 

commit 96ca4f3334b126ad972948d76add176a31116ca4 (release/2.2)
commit aa52ca828fc075e010c326e91d2171484a514fde (master)
Author: Simon Matter <simon.matter@invoca.ch>
Date:   Tue Mar 8 07:27:00 2011 +0000

    Fix issues with some older GCC compilers
    
    Some older GCC compilers don't like that variables are declared
    in the middle of the code, and expect them on the top in the
    block/scope.
    
    Trac-ticket: 99
    Signed-off-by: Simon Matter <simon.matter@invoca.ch>
    Acked-by: David Sommerseth <davids@redhat.com>
    Signed-off-by: David Sommerseth <davids@redhat.com>

May I please ask you to do a complete commit, and use git format-patch to generate patches. That way it's quicker and easier to accept patches. See the ​ Git crash course for more information. If you don't want to sign-up for the mailing list, you can upload the generated patches in the patch tracker.