Opened 2 years ago

Closed 2 years ago

#938 closed Patch submission (fixed)

"--bind ipv6only" not work

Reported by: hashiz Owned by: Gert Döring
Priority: major Milestone: release 2.4.5
Component: IPv6 Version: OpenVPN 2.4.0 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords: bind ipv6only
Cc: plaisthos

Description

--bind ipv6only option not work in 2.4.4

Attachments (2)

patch-src-openvpn-options.c (456 bytes) - added by hashiz 2 years ago.
fix patch
0001-fix-bind-ipv6only-no-work.patch (794 bytes) - added by hashiz 2 years ago.
patch for git am

Download all attachments as: .zip

Change History (8)

Changed 2 years ago by hashiz

Attachment: patch-src-openvpn-options.c added

fix patch

comment:1 Changed 2 years ago by Antonio

Hi, thanks for reporting and fixing this!

Would you mind creating a proper patch using git-format-patch and sending it over the mailing list with git-send-email?

Thanks!

Changed 2 years ago by hashiz

patch for git am

comment:2 Changed 2 years ago by hashiz

Please tell me email address to send a patch.

I could not find it on the wiki pages.

comment:3 Changed 2 years ago by Antonio

We have the openvpn-devel mailing list. You need to subscribe to be able to send emails:
https://sourceforge.net/projects/openvpn/lists/openvpn-devel

Also, I know the patch is quite trivial, but one or two lines in the commit message explaining why it does not work now would be good. Also, do you have any idea if it ever worked in the past?

Another thing: this is not necessarily needed, but if you could find and mention the commit that broke this feature it would be really appreciated!

Thanks

comment:4 Changed 2 years ago by Antonio

If for the future you need more indications about how to contribute to our project, please have a look at this page: https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation#Patchquality

Thanks again!

comment:5 Changed 2 years ago by Gert Döring

Cc: plaisthos added
Owner: set to Gert Döring
Status: newassigned

Now that's an interesting find. And apologies for letting this slip through - it was broken by the big option handling patch before 2.4.0, and it seems nobody actually wanted to use that option since then.

Taking the ticket so someone has the formal job to make sure it gets merged. But please send to openvpn-devel anyway, makes things more smooth for us.

comment:6 Changed 2 years ago by Gert Döring

Milestone: release 2.4.5
Resolution: fixed
Status: assignedclosed

thanks. Patch has been reviewed (easy enough) and merged to all affected branches.

commit cdeba63ca3a9e5c765edecd11745e9e2cc1b945d (master)
commit b0ef0003c554db34f5623a920874c97b22bc0224 (release/2.4)
Author: hashiz <hashiz@…>
Date: Thu Sep 28 12:16:20 2017 +0900

Fix '--bind ipv6only'

will be part of 2.4.5

Note: See TracTickets for help on using tickets.