Opened 4 years ago

Closed 8 months ago

#884 closed Bug / Defect (fixed)

client-disconnect script not passed any arguments

Reported by: hvenev Owned by: Gert Döring
Priority: major Milestone: release 2.5
Component: Configuration Version: OpenVPN 2.4.0 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description

No arguments seem to be passed to the client-disconnect script. According to the documentation it should be passed the same file given to client-connect.

Change History (5)

comment:1 Changed 4 years ago by tincantech

You might choose to enhance your question with some details. eg: configs/logs etc

comment:2 Changed 4 years ago by Gert Döring

Owner: set to Gert Döring
Status: newaccepted

This is a man page bug. It is very clear in stating that...

              The  --client-disconnect  command is passed the same pathname as
              the corresponding --client-connect command as its last argument.
              (after any arguments specified in cmd ).

but since there is no need for such a file (there is nothing that could be configured here, the client instance goes away right this moment), the code does not do it. No idea why the man page says so.

The man page change was done by Jonathan K. Bullard in commit d62859980c30362b36b7338fc99fe76e4ecb2cbd (cleaning up documentation in general), but I think the part about disconnect is just wrong. Since I ACKed the change, seems I'll have to fix it :-)

comment:3 Changed 8 months ago by Gert Döring

Milestone: release 2.5

Time to get this done!

comment:5 Changed 8 months ago by Gert Döring

Resolution: fixed
Status: acceptedclosed

commit 50c7700da09a1f83474e18f8709d59dbc4b509e2 (master)
commit 79910a3d2d78ec8c1b9becbd169eb9074fb242dd (release/2.5)
commit 9481cca682112b502f83afe537164fcdb0606e55 (release/2.4)
Author: Gert Doering
Date: Wed Sep 9 14:29:26 2020 +0200

Fix description of --client-disconnect calling convention in manpage.

Note: See TracTickets for help on using tickets.