Opened 7 years ago
Closed 4 years ago
#806 closed Bug / Defect (fixed)
Wrong Russian codepage in the installer window
Reported by: | mwz | Owned by: | Samuli Seppänen |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Installation | Version: | OpenVPN 2.4.0 (Community Ed) |
Severity: | Not set (select this one, unless your'e a OpenVPN developer) | Keywords: | |
Cc: | chipitsine@… |
Attachments (1)
Change History (20)
comment:1 Changed 7 years ago by
Cc: | chipitsine@… added |
---|
comment:2 Changed 7 years ago by
I added 1033 to current installer
https://github.com/OpenVPN/openvpn-build/blob/master/windows-nsis/openvpn.nsi#L621
it should not affect installation, I will have a look at it
thank for the report!
comment:3 Changed 7 years ago by
"Chipitsine is planning on making the installer Unicode"
Huh... It is not done yet, despite the OpenVPN does not support Win98 more, where thе non-unicode installer was required?
It is not the reproach, but simply the surprise: I do understand, that it not the most important thing to spend personal time. :)
Thanks for the reply and for your labor!
comment:4 Changed 7 years ago by
win2000 does not support unicode, win xp and more recent windows versions however are ok with unicode.
unicode was not supported by openvpn installer due to lacking unicode support in nsis <= 2.46, which is shipped in most linux distributives.
nsis-3.0 supports unicode and we are going to move to it soon.
Changed 7 years ago by
Attachment: | unicode.png added |
---|
comment:5 Changed 7 years ago by
I created unicode installer, however it does not help (please, see attachement)
https://community.openvpn.net/openvpn/raw-attachment/ticket/806/unicode.png
if you want to play with installer, you can download it here: http://chipitsine.github.io/openvpn-install-2.4.0-I601.exe (installer itself is signed, while binaries are not)
we see scrambled symbols because "net.exe" displays error in cp866, while gui is cp1251 (or unicode). it is known only for russian windows build.
we need to find better approach for handling "net.exe" error messages
comment:6 Changed 7 years ago by
Alas... It really does not help: the same picture.
I wondered why I didn't pay attention to the symbols with wrong codepage before — but now reinstalled openvpn-install-2.3.14-I601-x86_64.exe again and saw, that there are no diagnostic messages from net.exe there.
Then installed your new 2.4.0-I601.exe dated 07 Jan 2017, copied the messages from installer window, and converted CP-866 -> CP-1251 by the old Russian codepages converter "Shtirlitz-IV". All Russian words became readable after that.
Thank your for the clarification.
comment:7 Changed 7 years ago by
openvpn-2.4 introduced new interactive service (there's no such service in 2.3.14), also automatic service was replaced with c# one (which is installed in different way).
I made some improvement regarding trac#806: https://github.com/OpenVPN/openvpn-build/pull/69
I'll make installer soon. Hope it PR#69 will be merged before 2.4.1
comment:9 Changed 7 years ago by
seems that /OEM switch should do the job http://nsis.sourceforge.net/Docs/nsExec/nsExec.txt
however, it did not help.
as for libiconv, couple of things are not clear
1) how to integrate it with NSIS
2) how do determine from/to parameters (installer can run on any localization, i.e. french, german, chinese, etc)
comment:10 Changed 7 years ago by
/OEM switch works good for non-unicode NSIS (which is currently used) !
it seems that nsis3 got it broken.
ok, we resolved this issue
comment:11 Changed 7 years ago by
test installer: https://chipitsine.github.io/oem/openvpn-install-2.4.0-I601.exe
comment:12 Changed 7 years ago by
Confirm: all is Ok now.
Both in Windows-7 SP1 x64 RUS and in the latest Win-10 x64 Insider Preview.
Thank you!
comment:14 Changed 7 years ago by
Nice!
It is interesting, how many links will be found finally in this chain of "defects". :)
comment:17 Changed 4 years ago by
Owner: | set to Samuli Seppänen |
---|---|
Status: | new → assigned |
This sounds like it got fixed, and the ticket can be closed?
comment:18 Changed 4 years ago by
Milestone: | release 2.4 |
---|
Chipitsine is planning on making the installer Unicode, which would probably fix this issue.