Opened 22 months ago

Closed 21 months ago

Last modified 3 months ago

#739 closed Bug / Defect (fixed)

Make installation of openvpnserv2 look less scary

Reported by: Samuli Seppänen Owned by: Samuli Seppänen
Priority: major Milestone: beta 2.4
Component: Installation Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords: windows
Cc:

Description

Right now successful installation of openvpnserv2 produces lots of output that can look like an error, but it is in fact just too verbose.

Attachments (1)

redirect-test.nsi (744 bytes) - added by Samuli Seppänen 21 months ago.
Example NSIS script that hide sc.exe output, but warns the user on failure

Download all attachments as: .zip

Change History (6)

Changed 21 months ago by Samuli Seppänen

Attachment: redirect-test.nsi added

Example NSIS script that hide sc.exe output, but warns the user on failure

comment:1 Changed 21 months ago by Samuli Seppänen

There is no really clean way to hide command output in NSIS when using nsExec::<something>, because that function does not support I/O redirection. Running the command from within cmd.exe does the trick, though. It seems that sc.exe pushes everything into STDOUT even when there is a failure, so >nul silences sc.exe nicely. When OpenVPNServiceInteractive is not running, the "sc.exe start OpenVPNServiceInteractive" command will return 0, and when the service is (already) running, sc.exe returns 1056. The return value can be used to produce a less-verbose but still information message to the log view, as is done in the attached redirect-test.nsi script.

I will merge this functionality into openvpn.nsi and build new 2.4-alpha1 preview installers.

comment:2 Changed 21 months ago by Samuli Seppänen

A pull request that does this:

I'll merge it with lazy-ACK soon if there are no comments. I manually applied the patch to openvpn-build used to build openvpn-2.4_alpha1 installers.

Last edited 21 months ago by Samuli Seppänen (previous) (diff)

comment:3 Changed 21 months ago by Samuli Seppänen

The PR has been merged, closing.

comment:4 Changed 21 months ago by Samuli Seppänen

Resolution: fixed
Status: newclosed

comment:5 Changed 3 months ago by Playgame123

Many many thanks for the share this great information about the latest printing device you have the best way to connect http://addprinterwindows10.com/ i must be you can like to join in to the wireless this amazing device save the screen shot.

Note: See TracTickets for help on using tickets.