Opened 9 years ago
Closed 4 years ago
#632 closed Bug / Defect ( wontfix )
I60x installers should warn (or refuse cooperation) on XP
| Reported by: | Gert Döring | Owned by: | Samuli Seppänen |
|---|---|---|---|
| Priority: | major | Milestone: | release 2.3.14 |
| Component: | Generic / unclassified | Version: | OpenVPN 2.3.8 (Community Ed) |
| Severity: | Not set (select this one, unless your'e a OpenVPN developer) | Keywords: | |
| Cc: |
Description
$Colleague just installed 2.3.8 I601 on Windows XP, and it pretended a successful installation - but later on the TAP driver did not work ("could not access Tap adapter" from within OpenVPN).
We should print a warning, or just refuse installation and point to the I00x installers
Change History (16)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
in theory this sounds good - but in practice, when we merge valdikss' patch, the vista+ binaries will not run on XP anyway (due to missing DLL). So I think just telling the users "this is the wrong bundle for you" might be good enough...
Maybe rename the bundles as well, into openvpn-xp-I00x and openvpn-vista+-I60x?
comment:3 Changed 9 years ago by
Ah yes, that one. I'll wait until the dust settles and see what I can do.
comment:4 Changed 9 years ago by
An attempt to fix this was made in
commit 65e328
to openvpn-build. However, that fix caused odd issues on Windows XP, and it had to be reverted. Another fix is coming up.
comment:5 Changed 9 years ago by
| Milestone: | release 2.3.9 → release 2.3.11 |
|---|
comment:6 Changed 9 years ago by
| Milestone: | release 2.3.11 → release 2.3.12 |
|---|
comment:8 Changed 8 years ago by
this trac ticket might be closed after
https://github.com/OpenVPN/openvpn-build/commit/662c94d633f9d3cb70361d914389cf8130fc2d33
comment:9 Changed 8 years ago by
@chipitsine: I agree: this bug has been fixed in 2.4.x installers, and backporting the fix to 2.3.x installers is not worth the effort imho.
@cron2: any objections to closing this ticket as fixed?
comment:10 Changed 8 years ago by
Well, that depends - what happens if you install an 2.3-I60x installer on XP today?
If it still pretends "everything is good" then the bug has not been fixed - and since we're going to provide 2.3.x installers for quite a while to come, I see this still as something that
should
be fixed.
If we stop providing I60x installers, that would also work for XP users :-) - but I think folks on W8+ that do not trust 2.4 yet won't like that.
comment:11 Changed 8 years ago by
@mattock, can you please have a look at
https://github.com/OpenVPN/tap-windows6/pull/24
?
I do not own any EV code signing cert, it is tricky to build a package for me.
comment:13 Changed 8 years ago by
after
https://github.com/OpenVPN/tap-windows6/pull/24
is merged, probably we can close this issue
comment:14 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
@chipitsine: I don't think we've yet tested how OpenVPN 2.3.x-I60x installers behave on Windows XP when they launch a tap-windows6 installer with
the fix
.
comment:15 Changed 8 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Closed by accident, reopening.
comment:16 Changed 4 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | reopened → closed |
Since we do no longer provider any binary for XP, it seems we can now close this for real.
I think we should stop the installation and print a warning if the user has not unchecked the "Install/upgrade the TAP virtual device driver" checkbox. This will allow the I60x installers to work on Windows XP, as long as the user does not try install the tap-windows6 driver. Doing it like this is probably not any more work than bailing out immediately. The end result for most people is exactly the same.