Opened 11 years ago

Closed 11 years ago

#62 closed Patch submission (fixed)

Support SOCKS plain text authentication

Reported by: delroth Owned by: David Sommerseth
Priority: minor Milestone: beta 2.2
Component: Networking Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description

Hello,

The attached patch adds SOCKS plain text authentication support to OpenVPN. The socks-proxy option now takes an optional third parameter which is a file containing the SOCKS login credentials.

This patch will probably need to be reworked a bit as it's my first contribution to OpenVPN and I'm not quite familiar with both the coding style and the development process of this project :) .

I've been using this patch for two weeks now and it does not seem to cause any problem. The only modifications are in the SOCKS handshake handling and the options parser.

Please take a look at this patch.

Regards,
Pierre Bourdon.

Attachments (1)

openvpn-socks-auth.patch (7.4 KB) - added by delroth 11 years ago.
Adds support of SOCKS plain text authentication to OpenVPN

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by delroth

Attachment: openvpn-socks-auth.patch added

Adds support of SOCKS plain text authentication to OpenVPN

comment:2 Changed 11 years ago by delroth

Happy to be helpful! Let's hope that this patch will be accepted soon.

comment:3 Changed 11 years ago by delroth

Updated the patch to explain "magic numbers" in the code. Trac does not let me update the patch (it says the patch is spam...), an updated version can be found at http://delroth.net/openvpn-socks-auth.patch

comment:4 Changed 11 years ago by Gert Döring

Owner: set to David Sommerseth
Status: newassigned

ACKed in last week's meeting, to dazo for integration and to open a new Trac ticket "clean up the magic constant in the socks related code"

comment:5 Changed 11 years ago by David Sommerseth

Milestone: beta 2.2
Severity: Not set (if unsure, select this one)Patch Queue: In progress

comment:6 Changed 11 years ago by David Sommerseth

Component: Generic / unclassifiedNetworking

comment:7 Changed 11 years ago by David Sommerseth

Resolution: fixed
Severity: Patch Queue: In progressNot set (if unsure, select this one)
Status: assignedclosed

Applied to feat_misc, to be merged into allmerged and beta2.2

commit fc1fa9ffc7e3356458ec38d43816e5ddeb0c580a
Author: Pierre Bourdon <delroth@…>
Date: Mon Oct 11 00:56:04 2010 +0200

Adding support for SOCKS plain text authentication

This patch adds support for SOCKS plain text (username/password)
authentication as described in RFC 1929. It adds an optional third
parameter to the socks-proxy option, which is a file containing the
login credentials.


I've been using this patch for two weeks now and it does not seem to
cause any problem. The only modifications are in the SOCKS handshake
handling and the options parser.


Signed-Off-By: Pierre Bourdon <delroth@…>
Acked-by: Gert Doering <gert@…>
Acked-by: David Sommerseth <dazo@…>
Signed-off-by: David Sommerseth <dazo@…>

Note: See TracTickets for help on using tickets.