Opened 3 years ago

Closed 3 years ago

#582 closed Bug / Defect (fixed)

OCSP_check.sh does not work

Reported by: krbvroc1 Owned by: Steffan Karger
Priority: minor Milestone: release 2.3.11
Component: Generic / unclassified Version: OpenVPN 2.3.4 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description

Git commit 6ea78cbef6367590567156a20106c620fec224c9 (April 27, 2014) broke this routine.

The comitter replaced

if echo "$status" | grep -Fq "0x${serial}: good"; then

WITH

if echo "$status" | grep -Fq "${serial}: good"; then

Note in the second line above - an regex anchor tag is used. However grep is called with '-F' fixed strings which means looks for a literal, don't use regex. So this never matches. That same mistake was copied in commit e0c9e8452932a964b556daaeacdf7d9eab133e36 when an additional grep check was added.

I believe the patch is to replace the '-F' for grep with '-E'

I think the broke in 2.3.4 if I am reading the git logs correctly.

Change History (3)

comment:1 Changed 3 years ago by Gert Döring

Milestone: release 2.3.11
Owner: set to Steffan Karger
Status: newassigned

@syzzer: you broke it, you fix it :-) (that was easy)

  • thanks!

comment:2 Changed 3 years ago by Steffan Karger

Hm, strange that I did not notice this. Either way, apologies and patch sent to the list.

comment:3 Changed 3 years ago by Steffan Karger

Resolution: fixed
Status: assignedclosed

Your suggested fix has been committed to the master and release/2.3 branches. It will be part of OpenVPN 2.3.11 and later:
master: ab0f846de6991345c30f5b69817304183d347e0e
release/2.3: 22f399f5509a56c7aaa57779b14a650d33d30e5e

Note: See TracTickets for help on using tickets.