Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#557 closed Bug / Defect (fixed)

OpenVPN argument parsing of most options ignores "extra" parameters

Reported by: Samuli Seppänen Owned by:
Priority: major Milestone: release 2.4
Component: Generic / unclassified Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords: parser
Cc:

Description

OpenVPN's config parser silently ignores extra parameters given to options. This issue was reported to the openvpn-devel mailing list.

Change History (5)

comment:1 Changed 5 years ago by Samuli Seppänen

Quote from Samuli's IRC meeting summary: "Decided to make the config parser fail if erroneous extra
options are encountered."

comment:2 Changed 5 years ago by jkb

I have written a patch for this against the master branch, and will submit it after testing for the next few days. (There are changes to the processing of nearly every OpenVPN option.)

My impression from the IRC meeting log is that this should be fixed in 2.4 but not 2.3. Can anyone clarify that?

comment:3 Changed 5 years ago by Gert Döring

Resolution: fixed
Status: newclosed

A ticket to close \o/

commit 3d6a4cded2b20fb816b17d70eb65cd6c14a95eff
Author: Jonathan K. Bullard
Date: Tue Jun 2 08:43:26 2015 -0400

Fail if options have extra parameters [v2]

Acked-by: Arne Schwabe <arne@…>
Message-Id: <CAEsd45RvRfmqetu-EoFjSdyBk5F9X1K5muPGu-+_+30TMNOU_A@…>
URL: http://article.gmane.org/gmane.network.openvpn.devel/9783

comment:4 Changed 5 years ago by blueyed

This appears to break the down-root plugin, which requires an option.

See https://github.com/OpenVPN/openvpn/pull/27.

comment:5 Changed 5 years ago by Gert Döring

commit 82acf2163412aae9259e2202dbe001a2ac797b99
Author: Daniel Hahler <git@…>
Date: Sun Jul 19 21:55:22 2015 +0200

options: fix option check for "plugin"

Note: See TracTickets for help on using tickets.