Opened 7 years ago

Closed 5 years ago

#50 closed Bug / Defect (notabug)

Missing quotes and path check in easy-rsa batch files

Reported by: samuli Owned by: ecrist
Priority: major Milestone:
Component: Certificates Version: OpenVPN 2.1.0 / 2.1.1 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc: toddandmargo@…

Description

Hi All,

/openvpn-2.1_rc7/easy-rsa/Windows/

The batch scripts in easy-rsa are missing quotes around
the parameters that include file and path names. The
problem arises when the %KEY_DIR% variable has a space
in it (for example "C:\Program Files"). All command
lines with this variable should look like the following:

openssl ca -days 3650 -out "%KEY_DIR%\%1.crt" -in "%KEY_DIR%\%1.csr" -config %KEY_CONFIG%

Without the quotes, the commands crash and also create
a weird "C:\program" directory that freaks out Windows.

The offending scripts are:

build-ca.bat
build-ca-pass.bat
build-dh.bat
build-key-pass.bat
build-key-pkcs12.bat
build-key-server-pass.bat
build-key-server.bat
build-key.bat
clean-all.bat ----> all %d% should be "%d%"
revoke-full.bat

Also, you should include a "check path" routine at
the start of these scripts:

echo.
echo Unable to locate the directory pointed to by ^%KEY_DIR^% ^<%KEY_DIR%^>
echo Check and/or rerun Vars.bat
echo.
echo Cowardly exiting... (bummer)
echo.
exit
:okay

It also won't hurt you to put the CR-LF's at the
end of your lines. If you are using UNIX to
create these (Windows) files, "gedit" will do this for
you in its "Save As" function.

If you like, I volunteer to correct these files
for you. Just let me know where and how to send
them.

--Todd

ToddAndMargo? -at- verizon -dot- net

Change History (2)

comment:1 Changed 6 years ago by ecrist

  • Cc toddandmargo@… added
  • Owner set to ecrist
  • Status changed from new to accepted

If you can make the needed changes to the current files, or confirm this problem doesn't exist in the current source, please update this ticket with that information. Feel free to attach your patches to this ticket for review.

comment:2 Changed 5 years ago by ecrist

  • Resolution set to notabug
  • Status changed from accepted to closed

No reply from the author after 9 months.

Note: See TracTickets for help on using tickets.