Opened 13 years ago

Closed 11 years ago

#50 closed Bug / Defect (notabug)

Missing quotes and path check in easy-rsa batch files

Reported by: Samuli Seppänen Owned by: Eric Crist
Priority: major Milestone:
Component: Certificates Version: OpenVPN 2.1.0 / 2.1.1 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc: toddandmargo@…


Hi All,


The batch scripts in easy-rsa are missing quotes around
the parameters that include file and path names. The
problem arises when the %KEY_DIR% variable has a space
in it (for example "C:\Program Files"). All command
lines with this variable should look like the following:

openssl ca -days 3650 -out "%KEY_DIR%\%1.crt" -in "%KEY_DIR%\%1.csr" -config %KEY_CONFIG%

Without the quotes, the commands crash and also create
a weird "C:\program" directory that freaks out Windows.

The offending scripts are:

clean-all.bat ----> all %d% should be "%d%"

Also, you should include a "check path" routine at
the start of these scripts:

echo Unable to locate the directory pointed to by ^%KEY_DIR^% ^<%KEY_DIR%^>
echo Check and/or rerun Vars.bat
echo Cowardly exiting... (bummer)

It also won't hurt you to put the CR-LF's at the
end of your lines. If you are using UNIX to
create these (Windows) files, "gedit" will do this for
you in its "Save As" function.

If you like, I volunteer to correct these files
for you. Just let me know where and how to send


ToddAndMargo? -at- verizon -dot- net

Change History (2)

comment:1 Changed 12 years ago by Eric Crist

Cc: toddandmargo@… added
Owner: set to Eric Crist
Status: newaccepted

If you can make the needed changes to the current files, or confirm this problem doesn't exist in the current source, please update this ticket with that information. Feel free to attach your patches to this ticket for review.

comment:2 Changed 11 years ago by Eric Crist

Resolution: notabug
Status: acceptedclosed

No reply from the author after 9 months.

Note: See TracTickets for help on using tickets.