Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#489 closed Bug / Defect (fixed)

--tcp-no-delay kills client with ASSERT

Reported by: plaisthos Owned by: David Sommerseth
Priority: minor Milestone: release 2.3.7
Component: Generic / unclassified Version: OpenVPN 2.3.5 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description

Starting the client with --tcp-no-delay should give a warning/error instead of a confusing

Assertion failed at helper.c:537

Change History (3)

comment:1 Changed 6 years ago by David Sommerseth

Owner: set to David Sommerseth
Status: newassigned

Sent patch for review to the mailing list: http://thread.gmane.org/gmane.network.openvpn.devel/9334

comment:2 Changed 6 years ago by David Sommerseth

Resolution: fixed
Status: assignedclosed

Applied to the git master and release/2.3 branches, queued for next 2.3.7 release.

commit 706283d3765d1ee62dbd913fbfc191855b92528d (master)
commit 333566fd9d1951be97397f5f19d8bc78fb025af9 (release/2.3)
Author: David Sommerseth <davids@redhat.com>
Date:   Tue Dec 9 10:52:44 2014 +0100

    sockets: Remove the limitation of --tcp-nodelay to be server-only
    
    The assert(0) happening if trying to use --tcp-nodelay in a client
    config is really not helpful at all.  When this assert(0) was removed,
    another warning appeared that this could only be used in server
    configs.  That itself is also quite silly, as clients can choose to
    use --socket-flags TCP_NODELAY in the client config instead.  This
    behaviour does not help the user in any way.
    
    This patch removes the server-only restriction and rather provides
    a more helpful warning when using --tcp-nodelay on the client side.
    
    Trac: 489
    Signed-off-by: David Sommerseth <davids@redhat.com>
    Acked-by: Arne Schwabe <arne@rfc2549.org>
    Message-Id: 1418118764-17846-1-git-send-email-openvpn.list@topphemmelig.net
    URL: http://article.gmane.org/gmane.network.openvpn.devel/9334

comment:3 Changed 6 years ago by David Sommerseth

Duplicate tickets: #408, #429

Note: See TracTickets for help on using tickets.