Opened 6 years ago

Closed 5 years ago

#398 closed Bug / Defect (fixed)

socket.c does not compile with --disable-socks

Reported by: Gert Döring Owned by: Samuli Seppänen
Priority: major Milestone: release 2.4
Component: Generic / unclassified Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc: Samuli Seppänen

Description

#397 prodded me to test-compile master with the options he used - haven't checked whether it's --disable-socks or --enable-small, but one of them bombs master

../../../openvpn.git/src/openvpn/socket.c: In function 'do_preresolve':
../../../openvpn.git/src/openvpn/socket.c:266:13: error: 'struct connection_entry' has no member named 'socks_proxy_server'
../../../openvpn.git/src/openvpn/socket.c:269:14: error: 'struct connection_entry' has no member named 'socks_proxy_server'
../../../openvpn.git/src/openvpn/socket.c:270:14: error: 'struct connection_entry' has no member named 'socks_proxy_port'

plaisthos: please be fixing :-) - and then give the ticket to samuli to add a buildslave that builds with --enable-ssl, but --disable-server, --disable-socks, enable-small, and whatever else people do to "make it small" (see #397)

(Should you decide that --disable-socks is just not worth the bother and completely remove that, it would be a solution :-) )

Change History (5)

comment:1 Changed 6 years ago by Gert Döring

Owner: changed from plai to plaisthos
Status: newassigned

comment:2 Changed 5 years ago by Gert Döring

Owner: changed from plaisthos to Samuli Seppänen

Another easy one...

commit a4b8f653ee5be9c2292cf92dac09d7aadcc9a487
Author: Arne Schwabe <arne@…>
Date: Mon Jul 7 14:12:20 2014 +0200

Always enable http-proxy and socks-proxy

Acked-by: Gert Doering <gert@…>
Message-Id: <1404735142-31420-2-git-send-email-arne@…>
URL: http://article.gmane.org/gmane.network.openvpn.devel/8840

... to samuli: please revisit the buildbot variants - if we do not have one, --enable-small should be added, maybe --disable-server --enable-small as well. --disable-socks not, as Arne ripped out that option completely (thanks).

comment:3 Changed 5 years ago by Samuli Seppänen

Added "--enable-small" and "--disable-server --enable-small" to the buildmaster.

comment:4 Changed 5 years ago by Gert Döring

so we can close this? (assuming these two builds actually do not fail anywhere)?

comment:5 Changed 5 years ago by Samuli Seppänen

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.