Opened 6 years ago

Closed 5 years ago

#391 closed Bug / Defect (fixed)

src/openvpn/socket.c failed to compile for win32

Reported by: boj Owned by: plaisthos
Priority: major Milestone: release 2.4
Component: Building / Compiling Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords: win32
Cc:

Description

Commit 23d61c56b9fd218c39ad151b01b7e2d6690e6093 changed data structure of "struct link_socket_addr", but some code in #ifdef WIN32 was not updated accordingly, so the git master branch failed to compile for win32.

In src/openvpn/socket.c, function socket_recv_queue

int addrlen = af_addr_size(sock->info.lsa->local.addr.sa.sa_family);

Change History (3)

comment:1 Changed 6 years ago by Gert Döring

Milestone: release 2.4
Owner: set to plai
Status: newassigned

Yeah, we're aware, but this has been of slightly low priority (that code is plain weird and we wonder whether to rip it out altogether).

Thanks for formally reminding us by means of a ticket :-)

comment:2 Changed 6 years ago by Gert Döring

Owner: changed from plai to plaisthos

comment:3 Changed 5 years ago by Gert Döring

Resolution: fixed
Status: assignedclosed

Hah. This is an easy one to close - as Heiko and Arne did all the work :-)

commit 78b8fc720b6e6c31a889e4efaa28dbbc31da65ea
Author: Heiko Hund <heiko.hund@…>
Date: Sat Nov 15 17:25:07 2014 +0100

Fix compilation on Windows


The local member in struct link_socket_address went away a while ago.
Fixing the code to compile again under Windows. While there, also
fix the code to deal with struct link_socket_info.af == AF_UNSPEC

and

commit 188a65153fb304db873694eaab21599e37ead908
Author: Gert Doering <gert@…>
Date: Mon Nov 17 21:58:23 2014 +0100

Fix windows build on older mingw versions.


Add missing #define for IPV6_V6ONLY sockopt.

Note: See TracTickets for help on using tickets.