Small improvements to RHEL init script

[Simon Matter]

The small patch adds two features which makes life easier in our situation:

1) change the order when calling openvpn to --cd $work --config $c. That makes it possible to add another 'cd' to the config file. I didn't expect it but it really matters.

2) skip empty .conf and .sh files so nothing is called. That way we can deploy an empty dummy .conf file on hosts where no openvpn connection should run and still configure the service normally.

Thanks,
Simon

[Samuli Seppänen]

Hmm, yes, we do have RedHat init scripts in the main OpenVPN Git repository. Currently I'm building tons of Debian/Ubuntu packages and they too require a bunch of control files. Whether these should be stored in the main Git repository like RedHat init scripts are now, or kept separate, like Windows packaging files, is a matter of debate.

Whether we want to create packages for RedHat derivatives is also not clear. The RPMForge repos, for example, do a fairly good job in keeping up with latest OpenVPN releases, contrary to, say, Ubuntu and Debian. If we want to provide development snapshots then having internal RedHat packages available does make sense.

Any opinions?

[Gert Döring]

Samuli, so what to do wit this one? Have we decided where "package building stuff" goes to? (This applies to #9 as well)

[Gert Döring]

ping?

[Samuli Seppänen]

Packaging is currently handled outside openvpn:

• ​https://github.com/OpenVPN/openvpn-build (Windows)
• ​https://github.com/mattock/sbuild_wrapper (Debian/Ubuntu?)

To maintain consistency I'd prefer moving RPM packaging out of the main OpenVPN repository.

It would be great to have a volunteer that could maintain the RPM spec files, from which official and non-official RPM builds could be generated.

[David Sommerseth]

Fedora and Fedora EPEL .spec files can be found here: ​http://pkgs.fedoraproject.org/cgit/openvpn.git/

Those are actively maintained by the Fedora packagers. And they are the starting point when OpenVPN is decided to be packaged for RHEL as well.

Each branch in this repo targets a specific Fedora/EPEL release.

[David Sommerseth]

AFAICT, this has been resolved for Fedora EPEL 6 (RHEL 6), which uses upstart based init.d scripts.

​http://pkgs.fedoraproject.org/cgit/rpms/openvpn.git/tree/openvpn.init?h=el6

Even though RHEL 7 is systemd based, this also seems to have the suggested order.

​http://pkgs.fedoraproject.org/cgit/rpms/openvpn.git/tree/openvpn@.service?h=epel7

For a fix in the package distributed through ordinary RHEL6 channels, this must be fixed by Red Hat through their bugzilla. For RHEL7, OpenVPN is not shipped by Red Hat and you must use Fedora EPEL.