Opened 6 years ago

Closed 2 years ago

#272 closed TODO (General task list) (wontfix)

Port SVN r8126 ("Added remote-override option") to Git master

Reported by: Samuli Seppänen Owned by: Gert Döring
Priority: major Milestone: release 2.4
Component: Generic / unclassified Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description


Attachments (3)

8126.patch (1.2 KB) - added by Samuli Seppänen 6 years ago.
Git-am -style patch extracted from SVN using svnrev2git.py
8126-fixed.patch (920 bytes) - added by Samuli Seppänen 6 years ago.
Patch with fixed paths
0001-Added-remote-override-option.patch (1.5 KB) - added by Gert Döring 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Samuli Seppänen

Attachment: 8126.patch added

Git-am -style patch extracted from SVN using svnrev2git.py

comment:1 Changed 6 years ago by Samuli Seppänen

Status: newassigned

This patch will merge correctly with trivial changes, i.e. fixing the file paths.

Changed 6 years ago by Samuli Seppänen

Attachment: 8126-fixed.patch added

Patch with fixed paths

comment:2 Changed 6 years ago by Gert Döring

Thanks for all the work in preparing these "fixed" patches - unfortunately at least this one (8126-fixed.patch) is actually broken, as it lost "options.h".

So it's easier for me to work directly on the svn revisions, I think, so all the "translation mistakes" are my own to hunt...

Changed 6 years ago by Gert Döring

comment:3 Changed 6 years ago by Gert Döring

Patched, tested, seems to be well-behaved and do the right thing. Could use an entry in openvpn.8, but that's not in svn either...

Will do the full series, and then send to Samuli and James.

comment:4 Changed 4 years ago by Samuli Seppänen

Cron2: I assume this one could be closed?

comment:5 Changed 3 years ago by Gert Döring

*scratch head* seems it never got merged, even though it *did* get an ACK (after long discussion whether or not that feature is useful). Leaving it open for the time being, need to come back.

comment:6 Changed 3 years ago by Samuli Seppänen

Milestone: release 2.4

comment:7 Changed 2 years ago by David Sommerseth

Resolution: wontfix
Status: assignedclosed

This seems not to be needed any more. Closing as wontfix.

Note: See TracTickets for help on using tickets.