Opened 8 years ago

Closed 5 years ago

#212 closed Bug / Defect (fixed)

Windows installer places OpenVPN GUI shortcut even when GUI isn't installed

Reported by: Jernej Simončič Owned by: Samuli Seppänen
Priority: minor Milestone: release 2.4
Component: Installation Version: OpenVPN 2.2.2 (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc:

Description

Even if you unselect the OpenVPN GUI component during installation, the installer still places a (non-functional) OpenVPN GUI shortcut on the desktop.

Change History (4)

comment:1 Changed 8 years ago by David Sommerseth

Owner: set to Samuli Seppänen
Status: newassigned

comment:2 Changed 7 years ago by Samuli Seppänen

Milestone: release 2.4

I will check if this is still tue case and fix it for 2.4.

comment:3 Changed 5 years ago by Gert Döring

Owner: changed from Samuli Seppänen to Samuli Seppänen

comment:4 Changed 5 years ago by Samuli Seppänen

Resolution: fixed
Status: assignedclosed

This has been fixed at some point. Here's a snippet from openvpn-build/windows-nsis/openvpn.nsi:

!ifdef USE_OPENVPN_GUI
Section /o "${PACKAGE_NAME} GUI" SecOpenVPNGUI

        SetOverwrite on
        SetOutPath "$INSTDIR\bin"

        File "${OPENVPN_ROOT}\bin\openvpn-gui.exe"

        ${If} ${SectionIsSelected} ${SecAddShortcutsWorkaround}
                CreateDirectory "$SMPROGRAMS\${PACKAGE_NAME}"
                CreateShortCut "$SMPROGRAMS\${PACKAGE_NAME}\${PACKAGE_NAME} GUI.lnk" "$INSTDIR\bin\openvpn-gui.exe" ""
                CreateShortcut "$DESKTOP\${PACKAGE_NAME} GUI.lnk" "$INSTDIR\bin\openvpn-gui.exe"
        ${EndIf}
SectionEnd
!endif

The shortcut is clearly created in the openvpn-gui installation segment.

Closing as fixed.

Note: See TracTickets for help on using tickets.