#20 closed Bug / Defect (fixed)
Multiple --up scripts and no error
| Reported by: | David Sommerseth | Owned by: | David Sommerseth |
|---|---|---|---|
| Priority: | minor | Milestone: | beta 2.2 |
| Component: | Configuration | Version: | OpenVPN 2.1.0 / 2.1.1 (Community Ed) |
| Severity: | Patch Queue: In progress | Keywords: | |
| Cc: |
Description (last modified by )
Transferred from: http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719
It seems that openvpn doesn't allow multiple --up (probably --down, too) scripts in configuration file.
The problem is that if multiple up scripts are placed in configuration only one is run but unfortunately openvpn doesn't issue error message about duplicated entries.
There are two solutions:
1) issue error message if duplication happens
2) implement support for running multiple scripts with multiple "up" commands (just like multiple route commands are allowed). This one is prefered :-)
Response from janjust:
option 1 sounds like a good idea but then it would have to apply to *all*
options; if we do that then it becomes annoying to overrule a config file
option with a command-line option ...
option 2 is not an option.
Opinions?
Attachments (1)
Change History (8)
comment:1 Changed 13 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 13 years ago by
| Resolution: | → waiting for patch review |
|---|---|
| Status: | new → closed |
comment:3 Changed 13 years ago by
| Resolution: | waiting for patch review |
|---|---|
| Status: | closed → reopened |
comment:4 Changed 13 years ago by
| Milestone: | → beta 2.2 |
|---|---|
| Severity: | Not set (if unsure, select this one) → Patch Queue: New / awaiting ACK |
| Status: | reopened → assigned |
comment:5 Changed 13 years ago by
| Status: | assigned → accepted |
|---|
Changed 13 years ago by
| Attachment: | 0001-Fix-multiple-configured-scripts-conflicts-issue-vers.patch added |
|---|
[PATCH] Fix multiple configured scripts conflicts issue (version 2)
comment:6 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
Applied to bugfix2.1 and merged into allmerged.
commit ce722dc52bc062eb6e07f09133760579fd52f8dd
Author: David Sommerseth <dazo@…>
Date: Thu Aug 5 20:51:22 2010 +0200
Fix multiple configured scripts conflicts issue (version 2)
This is a fix for trac ticket #20,
<https://community.openvpn.net/openvpn/ticket/20>
which was started in the sf.net bug tracker:
<http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719>
The implemented solution is to give a warning for each of the different script hooks
available. The last configured script will override any earlier configured scripts,
to ensure that the command line can override the configuration file.
Signed-off-by: David Sommerseth <dazo@…>
Acked-by: James Yonan <james@…>
comment:7 Changed 13 years ago by
| Severity: | Patch Queue: New / awaiting ACK → Patch Queue: In progress |
|---|
Attached proposed fix:
commit 31e644dda8c543d68a0f50ed32b14426b637ea75
Author: David Sommerseth <dazo@…>
Date: Tue Jul 13 15:21:01 2010 +0200