Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#20 closed Bug / Defect (fixed)

Multiple --up scripts and no error

Reported by: dazo Owned by: dazo
Priority: minor Milestone: beta 2.2
Component: Configuration Version: 2.1.0 / 2.1.1
Severity: Patch Queue: In progress Keywords:
Cc:

Description (last modified by dazo)

Transferred from: http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719

It seems that openvpn doesn't allow multiple --up (probably --down, too) scripts in configuration file.

The problem is that if multiple up scripts are placed in configuration only one is run but unfortunately openvpn doesn't issue error message about duplicated entries.

There are two solutions:
1) issue error message if duplication happens
2) implement support for running multiple scripts with multiple "up" commands (just like multiple route commands are allowed). This one is prefered :-)


Response from janjust:

option 1 sounds like a good idea but then it would have to apply to *all*
options; if we do that then it becomes annoying to overrule a config file
option with a command-line option ...

option 2 is not an option.

Opinions?

Attachments (1)

0001-Fix-multiple-configured-scripts-conflicts-issue-vers.patch (4.5 KB) - added by dazo 6 years ago.
[PATCH] Fix multiple configured scripts conflicts issue (version 2)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by dazo

  • Description modified (diff)

comment:2 Changed 6 years ago by dazo

  • Resolution set to waiting for patch review
  • Status changed from new to closed

Attached proposed fix:

commit 31e644dda8c543d68a0f50ed32b14426b637ea75
Author: David Sommerseth <dazo@…>
Date: Tue Jul 13 15:21:01 2010 +0200

Fix multiple configured scripts conflicts issue


This is a fix for trac ticket #20,
<https://community.openvpn.net/openvpn/ticket/20>
which was started in the sf.net bug tracker:
<http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719>


The implemented solution is to give a warning for each of the different script
hooks available. The last configured script will override any earlier
configured scripts, to ensure that the command line can override the
configuration file.


Signed-off-by: David Sommerseth <dazo@…>

comment:3 Changed 6 years ago by dazo

  • Resolution waiting for patch review deleted
  • Status changed from closed to reopened

comment:4 Changed 6 years ago by dazo

  • Milestone set to beta 2.2
  • Severity changed from Not set (if unsure, select this one) to Patch Queue: New / awaiting ACK
  • Status changed from reopened to assigned

comment:5 Changed 6 years ago by dazo

  • Status changed from assigned to accepted

Changed 6 years ago by dazo

[PATCH] Fix multiple configured scripts conflicts issue (version 2)

comment:6 Changed 6 years ago by dazo

  • Resolution set to fixed
  • Status changed from accepted to closed

Applied to bugfix2.1 and merged into allmerged.

commit ce722dc52bc062eb6e07f09133760579fd52f8dd
Author: David Sommerseth <dazo@…>
Date: Thu Aug 5 20:51:22 2010 +0200

Fix multiple configured scripts conflicts issue (version 2)


This is a fix for trac ticket #20,
<https://community.openvpn.net/openvpn/ticket/20>
which was started in the sf.net bug tracker:
<http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719>


The implemented solution is to give a warning for each of the different script hooks
available. The last configured script will override any earlier configured scripts,
to ensure that the command line can override the configuration file.


Signed-off-by: David Sommerseth <dazo@…>
Acked-by: James Yonan <james@…>

comment:7 Changed 6 years ago by dazo

  • Severity changed from Patch Queue: New / awaiting ACK to Patch Queue: In progress
Note: See TracTickets for help on using tickets.