Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#20 closed Bug / Defect (fixed)

Multiple --up scripts and no error

Reported by: David Sommerseth Owned by: David Sommerseth
Priority: minor Milestone: beta 2.2
Component: Configuration Version: OpenVPN 2.1.0 / 2.1.1 (Community Ed)
Severity: Patch Queue: In progress Keywords:
Cc:

Description (last modified by David Sommerseth)

Transferred from: http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719

It seems that openvpn doesn't allow multiple --up (probably --down, too) scripts in configuration file.

The problem is that if multiple up scripts are placed in configuration only one is run but unfortunately openvpn doesn't issue error message about duplicated entries.

There are two solutions:
1) issue error message if duplication happens
2) implement support for running multiple scripts with multiple "up" commands (just like multiple route commands are allowed). This one is prefered :-)


Response from janjust:

option 1 sounds like a good idea but then it would have to apply to *all*
options; if we do that then it becomes annoying to overrule a config file
option with a command-line option ...

option 2 is not an option.

Opinions?

Attachments (1)

0001-Fix-multiple-configured-scripts-conflicts-issue-vers.patch (4.5 KB) - added by David Sommerseth 8 years ago.
[PATCH] Fix multiple configured scripts conflicts issue (version 2)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by David Sommerseth

Description: modified (diff)

comment:2 Changed 8 years ago by David Sommerseth

Resolution: waiting for patch review
Status: newclosed

Attached proposed fix:

commit 31e644dda8c543d68a0f50ed32b14426b637ea75
Author: David Sommerseth <dazo@…>
Date: Tue Jul 13 15:21:01 2010 +0200

Fix multiple configured scripts conflicts issue


This is a fix for trac ticket #20,
<https://community.openvpn.net/openvpn/ticket/20>
which was started in the sf.net bug tracker:
<http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719>


The implemented solution is to give a warning for each of the different script
hooks available. The last configured script will override any earlier
configured scripts, to ensure that the command line can override the
configuration file.


Signed-off-by: David Sommerseth <dazo@…>

comment:3 Changed 8 years ago by David Sommerseth

Resolution: waiting for patch review
Status: closedreopened

comment:4 Changed 8 years ago by David Sommerseth

Milestone: beta 2.2
Severity: Not set (if unsure, select this one)Patch Queue: New / awaiting ACK
Status: reopenedassigned

comment:5 Changed 8 years ago by David Sommerseth

Status: assignedaccepted

Changed 8 years ago by David Sommerseth

[PATCH] Fix multiple configured scripts conflicts issue (version 2)

comment:6 Changed 8 years ago by David Sommerseth

Resolution: fixed
Status: acceptedclosed

Applied to bugfix2.1 and merged into allmerged.

commit ce722dc52bc062eb6e07f09133760579fd52f8dd
Author: David Sommerseth <dazo@…>
Date: Thu Aug 5 20:51:22 2010 +0200

Fix multiple configured scripts conflicts issue (version 2)


This is a fix for trac ticket #20,
<https://community.openvpn.net/openvpn/ticket/20>
which was started in the sf.net bug tracker:
<http://sourceforge.net/tracker/?func=detail&aid=2078470&group_id=48978&atid=454719>


The implemented solution is to give a warning for each of the different script hooks
available. The last configured script will override any earlier configured scripts,
to ensure that the command line can override the configuration file.


Signed-off-by: David Sommerseth <dazo@…>
Acked-by: James Yonan <james@…>

comment:7 Changed 7 years ago by David Sommerseth

Severity: Patch Queue: New / awaiting ACKPatch Queue: In progress
Note: See TracTickets for help on using tickets.