early startup message printing is all confusing

[Gert Döring]

gert@ubuntu2004:~/t_server.git$ SU src/openvpn/openvpn --client --ca /home/gert/t_client_keys/ca.crt     --cert /home/gert/t_client_keys/cron2-ubuntu-2004-amd64.crt --key /home/gert/t_client_keys/cron2-ubuntu-2004-amd64.key  --remote-cert-tls server --nobind --verb 3         --tls-cert-profile insecure --providers legacy default --setenv UV_NOCOMP 1 --push-peer-info --dev tun471 --proto udp4 --remote conn-test-server.openvpn.org --port 51194
2022-07-21 19:54:30 Note: mbed TLS provider functionality is not available
2022-07-21 19:54:30 Note: mbed TLS provider functionality is not available
2022-07-21 19:54:30 Note: --cipher is not set. OpenVPN versions before 2.5 defaulted to BF-CBC as fallback when cipher negotiation failed in this case. If you need this fallback please add '--data-ciphers-fallback 'BF-CBC' to your configuration and/or add BF-CBC to --data-ciphers.
2022-07-21 19:54:30 net_iface_type: type of tun471: tun
2022-07-21 19:54:30 Interface tun471 exists and is non-DCO. Disabling data channel offload
2022-07-21 19:54:30 OpenVPN 2.6_git [git:05v11/11f03f2a5a0be586+] x86_64-pc-linux-gnu [SSL (mbed TLS)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] [DCO] built on Jul 21 2022

... can we please print the "this is openvpn version blabla" message BEFORE half the options warnings...?

[Selva Nair]

All those notes and comments before the greeting: "OpenVPN 2.6_git .... " is positively ugly.

By the way, the repeated warnings about mbed + provider is from crypt_load_provider() which is called for each provider. I think we should ignore "--providers foo" during option parsing in mbed TLS builds without making it a fatal error. Not sure why it appears so early in the logs though --- something to do with the init_early()?

Can we move msg(M_INFO, "%s", title_string); further up in the SIGHUP loop?

[Gert Döring]

I agree on the "providers" warnings, let's get these fixed as well :-)

On the "title_string" thing - I haven't looked into it in detail how to get the version info printed early without messing up output for functions that do not see any sort of version printout today, like "--genkey".