Opened 3 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#1461 closed Bug / Defect (fixed)

Missing cipher-negotiation.rst file and dependency in openvpn-2.5.6 tarball

Reported by: janm Owned by:
Priority: minor Milestone: release 2.5.7
Component: Building / Compiling Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords: cipher-negotiation.rst
Cc:

Description

The file doc/man-sections/cipher-negotiation.rst is missing from the from the openvpn-2.5.6 source tarball, making it hard to rebuild the openvpn(8) man page from source.

That file is also missing from the "openvpn_sections" assignment in doc/Makefile, meaning that the openvpn(8) man page won't get rebuilt if the man-sections/cipher-negotiation.rst file changes.

Attachments (1)

doc_Makefile.am.patch (354 bytes) - added by janm 3 months ago.
Patch to doc/Makefile.am to add doc/cipher-negotiation.rst

Download all attachments as: .zip

Change History (4)

Changed 3 months ago by janm

Attachment: doc_Makefile.am.patch added

Patch to doc/Makefile.am to add doc/cipher-negotiation.rst

comment:1 Changed 3 months ago by janm

The file doc/Makefile.am contains this comment:

# NOTE: Remember to add source .rst files to $(dist_noinst_DATA) below
# This could be automated with GNU Make, but we need BSD Make support

This has been forgotten for doc/man-sections/cipher-negotiation.rst. Trivial patch attached.

comment:2 Changed 6 weeks ago by Gert Döring

Keywords: cipher-negotiation.rst added
Resolution: fixed
Status: newclosed
Version: OpenVPN git master branch (Community Ed)

Thanks for reporting this, and sorry for being not very active wrt trac bugs.

This has now been merged to master and release/2.5

commit 7c8dd98ec10f61c3b014b64c24090717cd6ebf05 (master)
commit 1294064e142d43b49df66296f8cd92de0698616d (release/2.5)
Author: Jan Mikkelsen
Date: Wed May 18 20:37:15 2022 +0200

cipher-negotiation.rst missing from doc/Makefile.am

... and will be in the upcoming 2.5.7, to be released next tuesday.

comment:3 Changed 6 weeks ago by Gert Döring

Milestone: release 2.5.7
Note: See TracTickets for help on using tickets.