Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#14 closed Patch submission (fixed)

[PATCH] Handle non standard subnets in PF grammar

Reported by: Emmanuel Bretelle Owned by: David Sommerseth
Priority: minor Milestone: beta 2.2
Component: Networking Version: OpenVPN git master branch (Community Ed)
Severity: Patch Queue: In progress Keywords:
Cc:

Description

openvpn --version
OpenVPN 2.1.1g i686-pc-linux-gnu [SSL] [LZO2] [EPOLL] built on Jun 2 2010
Originally developed by James Yonan
Copyright (C) 2002-2010 OpenVPN Technologies, Inc. <sales@…>

Thread reference: http://permalink.gmane.org/gmane.network.openvpn.devel/3721

Allow 192.168.100.8/28 to be translated into 192.168.100.0/28 .

Previously OpenVPN was not handling properly the following pf_file:

# cat /dev/shm/openvpn_pf_73f2c3256a50371f057d5c0db97ede2f.tmp
[CLIENTS DROP]

[SUBNETS ACCEPT]
+192.168.100.0/29
-192.168.100.8/28

[END]

and was allowing packets to 192.168.100.8...192.168.100.15

With this patch, packets to 192.168.100.8...192.168.100.15 will be dropped.

This patch was made against git's bugfix2.1 branch commit 9ca155403ec72c7152bcb05c4bf8588c7cf2617b

Attachments (1)

0001-Handle-non-standard-subnets-in-PF-grammar.patch (2.1 KB) - added by Emmanuel Bretelle 10 years ago.
handle non standard subnets patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by David Sommerseth

Severity: unsetPatch Queue: New / awaiting ACK

Changed 10 years ago by Emmanuel Bretelle

handle non standard subnets patch

comment:2 Changed 10 years ago by Emmanuel Bretelle

updated patch to log warning when subnet is incorrect

comment:3 Changed 10 years ago by David Sommerseth

Owner: set to David Sommerseth
Priority: trivialminor
Severity: Patch Queue: New / awaiting ACKPatch Queue: In progress
Status: newaccepted

comment:4 Changed 10 years ago by David Sommerseth

Resolution: fixed
Status: acceptedclosed

Accepted and merged into bugfix2.1 and allmerged.

Commit f36470e42c1be1ace271033a0feb502b06f6b28e

comment:5 Changed 10 years ago by David Sommerseth

The merge commit was references instead of the patch itself. The patch is
commit a881843bf2101e77d15cb88105684288655055cb

comment:6 Changed 10 years ago by David Sommerseth

Milestone: beta 2.2
Note: See TracTickets for help on using tickets.