#137 closed Bug / Defect ( fixed )

Visual Studio 2008 builds fail on "master" branch

Reported by: Samuli Seppänen Owned by:
Priority: major Milestone: beta 2.3
Component: Building / Compiling Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc: gert@…

Description

It's not possible to build openvpn.exe from openvpn.git's "master" branch with Visual Studio 2008 due to compiler errors. Error log attached.

Attachments (12)

vs2008-build-errors.txt ​ ( 42.4 KB ) - added by Samuli Seppänen 14 years ago .
Visual Studio 2008 build errors
0001-Fixed-a-number-of-fatal-build-errors-on-Visual-Studi.patch ​ ( 2.4 KB ) - added by Samuli Seppänen 14 years ago .
Patch fixing a number of these build errors
vs-2008-build-errors-2.txt ​ ( 5.8 KB ) - added by Samuli Seppänen 14 years ago .
New build log after the (first) attached patch and commit 555fc5e have been applied
0001-Fix-Microsoft-Visual-Studio-incompatibility-in-plugin-c.patch ​ ( 2.5 KB ) - added by David Sommerseth 14 years ago .
Fixes more plug-in issues for MS Visual Studio
0001-Fixed-a-Visual-Studio-2008-build-error-in-tun.c.patch ​ ( 668 bytes ) - added by Samuli Seppänen 14 years ago .
Fix to tun.c build issue by cron2
0001-Fix-to-a-Visual-Studio-2008-build-error-in-options.c.patch ​ ( 691 bytes ) - added by Samuli Seppänen 14 years ago .
buildlog11.txt ​ ( 3.7 KB ) - added by Samuli Seppänen 14 years ago .
Build log of "master" branch with all patches in this ticket included
vs-2008-build-errors-4.txt ​ ( 5.5 KB ) - added by Samuli Seppänen 14 years ago .
New build log with the patches applied on top of a clean master branch. Notice tun.c build errors.
0001-Replace-32-bit-based-add_in6_addr-implementation-by-.patch ​ ( 1.9 KB ) - added by Gert Döring 14 years ago .
patch to change add_in6_addr() in socket.c to make it work on Windows
winbuildfix-log-1.txt ​ ( 16.4 KB ) - added by Samuli Seppänen 14 years ago .
Build logs of openvpn-testing.git's tmp/winbuildfix branch, when HEAD is at ddd65e4b5f55b
winbuildfix-log-2.txt ​ ( 14.8 KB ) - added by Samuli Seppänen 14 years ago .
Same as winbuildfix-log.txt, but after applying the "Additional Visual Studio 2008 build fixes to tun.c" patch
0001-Additional-Visual-Studio-2008-build-fixes-to-tun.c.patch ​ ( 1.2 KB ) - added by Samuli Seppänen 14 years ago .

.zip

Change History (17)

Changed 14 years ago by Samuli Seppänen

Visual Studio 2008 build errors

comment:1 Changed 14 years ago by David Sommerseth

Component: Generic / unclassified → Building / Compiling

The messages related to openvpn-plugin.h should be fixed with the following commit

commit 555fc5e34a9b1aca4bfa435023fe1aa336557ec7
Author: David Sommerseth <davids@redhat.com>
Date:   Fri Apr 29 13:28:06 2011 +0200

    Fix const declarations in plug-in v3 structs
    
    Microsoft Visual Studio complains about const char const **ptr declarations
    and expects them to be be const char ** const ptr.  The latter is what was the
    intention, that neither the pointer nor the value(s) it points at can be changed.
    
    Signed-off-by: David Sommerseth <davids@redhat.com>
    Acked-by: Gert Doering <gert@greenie.muc.de>

Changed 14 years ago by Samuli Seppänen

Patch fixing a number of these build errors

Changed 14 years ago by Samuli Seppänen

New build log after the (first) attached patch and commit 555fc5e have been applied

Changed 14 years ago by David Sommerseth

Fixes more plug-in issues for MS Visual Studio

Changed 14 years ago by Samuli Seppänen

Fix to tun.c build issue by cron2

Changed 14 years ago by Samuli Seppänen

Attachment: buildlog11.txt ​ added

Build log of "master" branch with all patches in this ticket included

Changed 14 years ago by Samuli Seppänen

New build log with the patches applied on top of a clean master branch. Notice tun.c build errors.

Changed 14 years ago by Gert Döring

patch to change add_in6_addr() in socket.c to make it work on Windows

comment:2 Changed 14 years ago by Gert Döring

Cc: gert@… added

Changed 14 years ago by Samuli Seppänen

Build logs of openvpn-testing.git's tmp/winbuildfix branch, when HEAD is at ddd65e4b5f55b

Changed 14 years ago by Samuli Seppänen

Same as winbuildfix-log.txt, but after applying the "Additional Visual Studio 2008 build fixes to tun.c" patch

comment:3 Changed 14 years ago by Samuli Seppänen

Final Visual studio compile fixes are available ​ here and have been ACKed. Apply these on top of tmp/winbuildfix branch (based on "master") and VS builds work again.

comment:4 Changed 14 years ago by Samuli Seppänen

Milestone: → beta 2.3

comment:5 Changed 13 years ago by David Sommerseth

Resolution: → fixed
Status: new → closed
Version: 2.3-beta / 2.3-RC → git master branch

I believe this is fixed and needed patches have reached the master branch., so closing this one. Please re-open if there are more issues.