2.5.0: test suite build fails

[kloczek]

[tkloczko@barrel openvpn-2.5.0]$ make check
make  check-recursive
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0'
Making check in build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build'
Making check in msvc
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build/msvc'
Making check in msvc-generate
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build/msvc/msvc-generate'
make[4]: Nothing to be done for 'check'.
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build/msvc/msvc-generate'
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build/msvc'
make[4]: Nothing to be done for 'check-am'.
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build/msvc'
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build/msvc'
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build'
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/build'
Making check in distro
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/distro'
Making check in systemd
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/distro/systemd'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/distro/systemd'
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/distro'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/distro'
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/distro'
Making check in include
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/include'
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/include'
Making check in src
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src'
Making check in compat
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/compat'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/compat'
Making check in openvpn
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/openvpn'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/openvpn'
Making check in openvpnmsica
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/openvpnmsica'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/openvpnmsica'
Making check in openvpnserv
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/openvpnserv'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/openvpnserv'
Making check in plugins
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins'
Making check in auth-pam
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins/auth-pam'
make[4]: Nothing to be done for 'check'.
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins/auth-pam'
Making check in down-root
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins/down-root'
make[4]: Nothing to be done for 'check'.
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins/down-root'
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins'
make[4]: Nothing to be done for 'check-am'.
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins'
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/plugins'
Making check in tapctl
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/tapctl'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src/tapctl'
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src'
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/src'
Making check in sample
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/sample'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/sample'
Making check in doc
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/doc'
Making check in doxygen
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/doc/doxygen'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/doc/doxygen'
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/doc'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/doc'
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/doc'
Making check in tests
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests'
Making check in unit_tests
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests'
Making check in example_test
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/example_test'
make  example_testdriver example2_testdriver
make[5]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/example_test'
make[5]: 'example_testdriver' is up to date.
make[5]: 'example2_testdriver' is up to date.
make[5]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/example_test'
make  check-TESTS
make[5]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/example_test'
[==========] Running 2 test(s).
[ RUN      ] null_test_success
[       OK ] null_test_success
[ RUN      ] int_test_success
[       OK ] int_test_success
[==========] 2 test(s) run.
[  PASSED  ] 2 test(s).
PASS: example_testdriver
[==========] Running 1 test(s).
[ RUN      ] test_true
[       OK ] test_true
[==========] 1 test(s) run.
[  PASSED  ] 1 test(s).
PASS: example2_testdriver
==================
All 2 tests passed
==================
make[5]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/example_test'
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/example_test'
Making check in openvpn
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/openvpn'
make  argv_testdriver buffer_testdriver crypto_testdriver packet_id_testdriver auth_token_testdriver ncp_testdriver tls_crypt_testdriver
make[5]: Entering directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/openvpn'
/bin/sh ../../../libtool  --tag=CC   --mode=link gcc -I../../../include  -I../../../src/openvpn -I../../../src/compat -Wall -Wno-unused-parameter -Wno-unused-function -Wno-stringop-truncation -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -std=c99 -lssl -lcrypto  -lpkcs11-helper -lssl -lcrypto  -llzo2 -lcmocka  -L../../../src/openvpn -Wl,--wrap=parse_line -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o argv_testdriver argv_testdriver-test_argv.o argv_testdriver-mock_msg.o argv_testdriver-mock_get_random.o argv_testdriver-platform.o argv_testdriver-buffer.o argv_testdriver-argv.o
libtool: link: gcc -I../../../include -I../../../src/openvpn -I../../../src/compat -Wall -Wno-unused-parameter -Wno-unused-function -Wno-stringop-truncation -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -std=c99 -Wl,--wrap=parse_line -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o argv_testdriver argv_testdriver-test_argv.o argv_testdriver-mock_msg.o argv_testdriver-mock_get_random.o argv_testdriver-platform.o argv_testdriver-buffer.o argv_testdriver-argv.o  -lpkcs11-helper -lssl -lcrypto -llzo2 -lcmocka -L../../../src/openvpn
/usr/bin/ld: argv_testdriver.lto.o: in function `argv_parse_cmd.constprop.0':
/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/openvpn/../../../src/openvpn/argv.c:490: undefined reference to `__wrap_parse_line'
collect2: error: ld returned 1 exit status
make[5]: *** [Makefile:754: argv_testdriver] Error 1
make[5]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/openvpn'
make[4]: *** [Makefile:2023: check-am] Error 2
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests/openvpn'
make[3]: *** [Makefile:420: check-recursive] Error 1
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests/unit_tests'
make[2]: *** [Makefile:474: check-recursive] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0/tests'
make[1]: *** [Makefile:612: check-recursive] Error 1
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/openvpn-2.5.0'
make: *** [Makefile:910: check] Error 2

[Gert Döring]

cc'ing in @dazo, as "rpmbuild" very much sounds like "some sort of unnamed RedHat? Linux"

The error message is a link error, not finding one of the libcmocka provided functions - so something is wrong with cmocka or with our configure. Either it should determine "cmocka not there" and then just not run cmocka-requiring tests, or the tests should pass.

[David Sommerseth]

This is pretty scarce on details. Which distro was used? Was yum-builddep ran against the openvpn.spec file before running rpmbuild? Did you try mock -r $DISTRO openvpn-2.5.0.src.rpm?

[Gert Döring]

With no feedback, we can't do anything here.