#1230 closed Bug / Defect (fixed-external)
warnings in windows build
Reported by: | Antonio Quartulli | Owned by: | stipa |
---|---|---|---|
Priority: | major | Milestone: | release 2.5 |
Component: | Generic / unclassified | Version: | |
Severity: | Not set (select this one, unless your'e a OpenVPN developer) | Keywords: | |
Cc: |
Description
<pre>
manage.c: In function 'man_read':
manage.c:2171:40: error: pointer targets in passing argument 2 of 'recv' differ in signedness [-Werror=pointer-sign]
len = recv(man->connection.sd_cli, buf, sizeof(buf), MSG_NOSIGNAL);
In file included from ../../src/compat/compat.h:28,
from syshead.h:27,
from manage.c:30:
/usr/share/mingw-w64/include/winsock2.h:992:34: note: expected 'char *' but argument is of type 'unsigned char *'
WINSOCK_API_LINKAGE int WSAAPI recv(SOCKET s,char *buf,int len,int flags);
~
In file included from mtu.h:27,
from options.h:34,
from manage.c:36:
manage.c: In function 'man_write':
buffer.h:124:21: error: pointer targets in passing argument 2 of 'send' differ in signedness [-Werror=pointer-sign]
#define BPTR(buf) (buf_bptr(buf))
~
~
buffer.h:124:21: note: in definition of macro 'BPTR'
#define BPTR(buf) (buf_bptr(buf))
~
In file included from ../../src/compat/compat.h:28,
from syshead.h:27,
from manage.c:30:
/usr/share/mingw-w64/include/winsock2.h:997:34: note: expected 'const char *' but argument is of type 'uint8_t *' {aka 'unsigned char *'}
WINSOCK_API_LINKAGE int WSAAPI send(SOCKET s,const char *buf,int len,int flags);
~
cc1: all warnings being treated as errors
</pre>
Change History (2)
comment:1 Changed 4 years ago by
Owner: | changed from lev to stipa |
---|
comment:2 Changed 4 years ago by
Resolution: | → fixed-external |
---|---|
Status: | assigned → closed |
I'll just close this. Lev will undoubtly send more warning fix patches over time, so no need to keep this ticket open.
Is this still relevant? We've fixed quite a few windows warnings