Opened 6 years ago

Closed 4 years ago

#1186 closed Feature Wish ( fixed )

get rid of PLUGIN_DEF_AUTH

Reported by: Gert Döring Owned by: Antonio Quartulli
Priority: major Milestone: release 2.6
Component: Building / Compiling Version: OpenVPN git master branch (Community Ed)
Severity: Not set (select this one, unless your'e a OpenVPN developer) Keywords:
Cc: plaisthos

Description

In the discussion of

​ https://patchwork.openvpn.net/patch/451/

we came to the conclusion that we do not want "more #ifdef" but that it makes sense to get rid of the whole conditional package of PLUGIN_DEF_AUTH .

Since that was nearly a year ago, I'm turning this into a trac ticket with milestone 2.5 so that we might remember.

Change History (6)

comment:1 Changed 5 years ago by Gert Döring

*bump*

comment:2 Changed 5 years ago by Gert Döring

*bump*

It's not that many left... and now's the time

$ git grep PLUGIN_DEF_AUTH
src/openvpn/ssl.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_common.h:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_verify.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_verify.c:#endif /* ifdef PLUGIN_DEF_AUTH */
src/openvpn/ssl_verify.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_verify.c:#endif /* PLUGIN_DEF_AUTH */
src/openvpn/ssl_verify.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_verify.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_verify.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_verify.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl_verify.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/syshead.h:#define PLUGIN_DEF_AUTH
src/openvpn/syshead.h:#if !defined(PLUGIN_DEF_AUTH) && !defined(MANAGEMENT_DEF_AUTH)

comment:3 Changed 5 years ago by Gert Döring

*bump bump*

comment:4 Changed 4 years ago by Gert Döring

Milestone: release 2.5 → release 2.6

commit 99d217b20064e7fef90dfa49bdcbab23ea7fbcb3
Author: Arne Schwabe <arne@…>
Date: Fri Oct 23 13:32:44 2020 +0200

Remove --disable-def-auth configure argument

which was after 2.5 release, so this went into master only.

BUT one instance of PLUGIN_DEF_AUTH managed to survive in src/openvpn/ssl.c... 

src/openvpn/ssl.c:#ifdef PLUGIN_DEF_AUTH
src/openvpn/ssl.c-    key_state_rm_auth_control_files(ks);
src/openvpn/ssl.c-#endif

Fix!

comment:5 Changed 4 years ago by Gert Döring

Cc: plaisthos added

comment:6 Changed 4 years ago by Gert Döring

Resolution: → fixed
Status: assigned → closed

commit 997b006a266145c2797f7625eccb6f3623b7a59c
Author: Gert Doering
Date: Thu Apr 1 10:29:34 2021 +0200

Get rid of last PLUGIN_DEF_AUTH #ifdef