2012-03-15 – community wiki

**NOTE:** The ACK status of these patches is now tracked on [this wiki page](wiki:GenericBuildsystemIntegration). Please do not update this page anymore.

# Generic development topics

- Which Microsoft Visual Studio versions do we want to support in the new "msvc" buildsystem written by Alon Bar-Lev?
- Move official openvpn project repositories into GitHub (creating organization etc...) Much easier to cooperate at GitHub than at SourceForge!

# Documentation

Look [here](wiki:BuildingUsingGenericBuildsystem).

# Patches

The following patchsets have been ACKed only partially, and there's a feature freeze until they have been merged. The goal of this meeting is to review the un-ACKed patches.

All available at [github](https://github.com/alonbl).

# Tap-windows patchset

These messages are viewable from [here](http://thread.gmane.org/gmane.network.openvpn.devel/5817).

A total new repository was created, preserving history. The patches are available [here](https://github.com/alonbl/tap-windows).

**PLEASE** clone this as-is when approved.

| **Patch name** | **ACKed by** | **Notes** |
|----------------|--------------|-----------|
| [tap-windows 03/11] cleanup: remove warnings of redefinition of macros | | |
| [tap-windows 04/11] debug: add !DbgPrint support | | |
| [tap-windows 05/11] build: set default to newer ddk | | |
| [tap-windows 06/11] cleanup: replace TAP-Win32->TAP-Windows | | |
| [tap-windows 08/11] cleanup: add TAP_WIN prefix to exports | | |
| [tap-windows 09/11] cleanup: create .gitignore | | |
| [tap-windows 10/11] docs: add COPYING COPYRIGHT.GPL | | |
| [tap-windows 11/11] build: initial build | | |

# Easy-rsa patchset

These messages are viewable from [here](http://thread.gmane.org/gmane.network.openvpn.devel/5799).

A total new repository was created, preserving history. The patches are available [here](https://github.com/alonbl/easy-rsa).

**PLEASE** clone this as-is when approved.

| **Patch name** | **ACKed by** | **Notes** |
|----------------|--------------|-----------|
| [easy-rsa 1/4] cleanup: fix execute permission | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5799/focus=5937) | |
| [easy-rsa 2/4] build: simple autotools build | [samuli (feature-ACK only)](http://thread.gmane.org/gmane.network.openvpn.devel/5799/focus=5938) | |
| [easy-rsa 3/4] build: doc | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5799/focus=5939) | ACK only if easy-rsa 2/4 was sane autotools-vise |
| [easy-rsa 4/4] packaging: rpm: initial add | [samuli (feature-ACK only)](http://thread.gmane.org/gmane.network.openvpn.devel/5799/focus=5940) | |

# OpenVPN-GUI build rewrite patchset

These messages are viewable from [here](http://thread.gmane.org/gmane.network.openvpn.devel/5795).

The patches are available [here](https://github.com/alonbl/openvpn-gui/tree/build).

**PLEASE** pull when approved.

| **Patch name** | **ACKed by** | **Notes** |
|----------------|--------------|-----------|
| [openvpn-gui 1/8] cleanup: resolve unused parameter warnings | | |
| [openvpn-gui 2/8] cleanup: resolve warnings missing malloc include | | |
| [openvpn-gui 3/8] debug: fix debug under unicode | | |
| [openvpn-gui 4/8] cleanup: add missing stdlib.h | | |
| [openvpn-gui 5/8] cleanup: dos2unix res/openvpn-gui-res-fi.rc | | |
| [openvpn-gui 6/8] cleanup: dos2unix res/openvpn-gui-res-jp.rc | | |
| [openvpn-gui 7/8] cleanup: dos2unix OpenVPN GUI ReadMe.txt | | |
| [openvpn-gui 8/8] build: rework build | | |

# Build revolution patchset

These messages are viewable from [here](http://thread.gmane.org/gmane.network.openvpn.devel/5772).

The patches are available [here](https://github.com/alonbl/openvpn/tree/build).

**PLEASE** pull when approved. There were some changes regarding the msvc build.

| **Patch name** | **ACKed by** | **Notes** |
|----------------|--------------|-----------|
| [PATCH 01/52] build: version should not contain '-' | dazo | Helps with RPMs and debs don't care. |
| [PATCH 02/52] package: rpm: strip should be handled by package managem | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5884) | |
| [PATCH 03/52] cleanup: options.c: remove redundant include | andj, samuli | |
| [PATCH 04/52] cleanup: remove C++ warnings | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5886) | |
| [PATCH 05/52] cleanup: win32.c: wrong printf format | andj, dazo | this is correct: WCHAR *cmd = wide_string (a->argv[0], &gc); |
| [PATCH 06/52] cleanup: remove redundant ';' | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5887) | |
| [PATCH 07/52] cleanup: crypto_openssl.c: remove support for pre-openss | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5888) | |
| [PATCH 08/52] cleanup: tun.c: fix incorrect option in message (ip-win3 | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5889) | |
| [PATCH 09/52] cleanup: memcmp.c: remove unused source | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5891) | |
| [PATCH 10/52] fixup: init.c: add missing conditional for ENABLE_CLIENT | andj, dazo | forward.h was included twice, good fix |
| [PATCH 11/52] build: correct place to alter WINVER is at build system | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5892) | |
| [PATCH 12/52] Update .gitignore | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5893) | |
| [PATCH 13/52] build: handle printf style format in mingw | dazo | |
| [PATCH 14/52] build: rename plugin directory to plugins | dazo | |
| [PATCH 15/52] build: plugins: properly use CC, CFLAGS and LDFLAGS | andj, dazo | |
| [PATCH 16/52] build: we need the sample.ovpn in future | dazo | [Samuli's comments](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5894). Dazo: "I'd say ACK, and we'll improve this later on" |
| [PATCH 17/52] Remove install-win32 | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5896) | |
| [PATCH 18/52] Remove easy-rsa | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5895) | |
| [PATCH 19/52] Remove tap-win32 | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5898) | |
| [PATCH 20/52] cleanup: rename tap-windows function from win32 to win | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5895) | |
| [PATCH 21/52] build: remove windows specific build system | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5903) | |
| [PATCH 22/52] build: split acinclude.m4 into m4/* | andj | |
| [PATCH 23/52] build: m4/ax_varargs.m4: cleanup | dazo | |
| [PATCH 24/52] build: m4/ax_emptyarray.m4: cleanup | dazo | |
| [PATCH 25/52] build: m4/ax_socklen_t.m4: cleanup | dazo | |
| [PATCH 26/52] build: autotools: first pass of trivial autotools change | andj, dazo | Simple cleanups |
| [PATCH 27/52] build: autoconf: remove OPENVPN_ADD_LIBS useless macro | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5919) | |
| [PATCH 28/52] build: remove awk and non-standard autoconf output proce | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5920) | |
| [PATCH 29/52] build: standard directory layout | andj | Available [here](https://github.com/alonbl/openvpn/commit/f26b8c6e498184eb53dd74eff40f205358e72404). andj: "compliments for cleaning that up" |
| [PATCH 30/52] build: add libtool + windows resources for executables | dazo, mattock | Fix the COMPANY_NAME and LEGAL_COPYRIGHT later |
| [PATCH 31/52] build: autoconf: commands as environment | andj | comments from [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5921) and [alon](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5948) |
| [PATCH 32/52] build: libdl usage | andj, dazo | |
| [PATCH 33/52] build: properly detect and use socket libs | dazo | [samuli's comments](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5922) |
| [PATCH 34/52] build: autoconf: minor cleanups | andj, dazo | |
| [PATCH 35/52] build: proper selinux detection and usage | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5954) | |
| [PATCH 36/52] build: distribute pkg.m4 | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5924) | |
| [PATCH 37/52] build: proper pkcs11-helper detection and usage | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5925) | |
| [PATCH 38/52] build: properly process lzo-stub | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5926) | |
| [PATCH 39/52] build: proper lzo detection and usage | andj, dazo | Discuss on the ml whether lzo should be enabled by default |
| [PATCH 40/52] build: proper crypto detection and usage | andj | andj: OpenSSL 0.9.6 needs to go |
| [PATCH 41/52] build: autoconf: update defaults for options | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5927) | |
| [PATCH 42/52] build: win-msvc: msbuild format | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5928) | |
| [PATCH 43/52] build: move out config.h include from syshead | dazo | |
| [PATCH 44/52] build: split out compat | dazo, [samuli (feature-ACK only)](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5929) | |
| [PATCH 45/52] build: move gettimeofday() emulation to compat | dazo | Removes #ifdefs, cleans up the code |
| [PATCH 46/52] build: move daemon() emulation into compat | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5930) | |
| [PATCH 47/52] build: move inet_ntop(), inet_pton() emulation into comp | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5952) | |
| [PATCH 48/52] cleanup: move console related function into its own modu | [samuli (feature-ACK only)](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5932) | |
| [PATCH 49/52] build: move wrappers into platform module | [samuli (feature-ACK only)](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5953) | |
| [PATCH 50/52] build: windows: install version.sh to allow installer re | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5951) | |
| [PATCH 51/52] build: distribute samples in windows | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5935) | Provided [this analysis](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5935) is correct |
| [PATCH 52/52] build: use tap-windows.h as external dependency | [samuli](http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5936) | |

# Build system

Available [here](https://github.com/alonbl/openvpn-build).