Opened 8 years ago
Closed 4 years ago
#719 closed Feature Wish (fixed)
replace ctime with POSIX time format
| Reported by: | Gert Döring | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | release 2.5 |
| Component: | Generic / unclassified | Version: | OpenVPN git master branch (Community Ed) |
| Severity: | Not set (select this one, unless your'e a OpenVPN developer) | Keywords: | |
| Cc: |
Description
if we time-stamp "things" today, we use time_string() in otime.c, which uses ctime() underneath - which has this weird "Thu Nov 24 18:22:48 1986" time format - neither sortable, nor particularily nice for humans either.
People have approached me to replace this with POSIX time stamping (2016-08-11 10:45:03).
The change is trivial, but the potential users of time_string need to be looked at, if anything relies on that time format.
(Logging using --machine-readable-timestamp is not affected, neither is syslogging)
Change History (4)
comment:1 Changed 8 years ago by
| Milestone: | → release 2.4 |
|---|
comment:2 Changed 7 years ago by
| Milestone: | release 2.4 → release 2.5 |
|---|
comment:3 Changed 4 years ago by
Took a bit to remember this
Patch is at
https://patchwork.openvpn.net/patch/1156/
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20040.html
let's see what people think.
comment:4 Changed 4 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
commit ff063b6f19e035da56fbf49c891e6376543b391d
Author: Gert Doering <gert@…>
Date: Sat Jun 20 19:23:03 2020 +0200
Change timestamps in file-based logging to ISO 8601 time format.
merged & pushed (for 2.5-only)
we decided that we're not going to make a change that fundamental "in the release end-run", so bumping to 2.5