| | 102 | |
| | 103 | * about removing snappy support - we keep it for the time being (#ifdef), because OpenVPN 3 and OpenVPN AS support an use it. Since compression can be negotiated, we can just leave it off for platforms where it is complicated to build (like Windows due to libstdc++.dll being so big) |
| | 104 | |
| | 105 | * coding style in OpenVPN source - see http://blue.bikeshed.org/ and http://en.wikipedia.org/wiki/Indent_style - candidates: Allmann, GNU, K&R (higher git impact when changing over due to the opening bracket moving), and then tabs/no-tabs. |
| | 106 | * everybody is "okayish" with changing, as long as it is done consistent, everywhere |
| | 107 | * slighly stronger feeling for Allmann style - ** Allmann style ** it is |
| | 108 | * syzzer voluntereers to make the non-consistent files consistent |
| | 109 | * "the big whitespace change" for existing code happens at 2.4-RC, and then we will no longer do "patches to master and 2.3" (which would have different indentation) but to "master and 2.4" (same style), except for critical issues, which usually are small and manageable |
| | 110 | * line length? |
| | 111 | * "stick to what we have for now", do not reformat arbitrarily |
| | 112 | * breaking a line in the middle: align to opening (round) brackets in line above |
| | 113 | * tabs vs. spaces: "not mixed" |
| | 114 | * majority for "only spaces, no tabs" |
| | 115 | * this is what we change to: all spaces |
| | 116 | |
