Changes between Version 38 and Version 39 of KarlsruheHackathon2017

Timestamp:

11/11/17 15:34:24 (6 years ago)

Author:

David Sommerseth

Comment:

adding argv

KarlsruheHackathon2017

@@ -74 +74 @@
    * UI while installing is not required or kept to the minimum.
    * MSI packages are also to be packed into an EXE installer for end-users.
+
  * route.c / tun.c rehaul (ordex, dazo, cron2, jjk)
    * Linux support for ifconfig/route is dropped
@@ -83 +84 @@
    * we look into splitting tun.c into tun-unix.c and tun-win32.c, but not tun-{linux,freebsd,netbsd,solaris,...].c, for the same reasons
    * tun.c needs to see all those nearly-identical tun_read()/tun_write() functions merged into one place, and then we see what else is copy-paste code reuse
+
  * Vagrant (dazo, mattock, cron2, lev, johan, antonio)
    * we have a few use-cases for Vagrant
@@ -92 +94 @@
     * setup a t_client style server setup that can be used for manual testing
     * integrate client and server parts together with more automation
+
 * block-ipv6 patch
   * considered good idea, arne will cleanup patch and resend patch
-
 
  * `--tls-cert-profile`
@@ -102 +104 @@
    * Steffan will send a v2 of the mbed patch that will print a warning for openssl build, instead of refusing to start, if --tls-cert-profile is used.
    * Steffan will later send a patch to implement the seclevel approach for openssl.
+
+* argv processing clean-up (David, Heiko)
+  * Heiko has some patches on the ML which have been awaiting some updates since last Hackathon; approximately half of the patch-set have been applied but the rest have been lingering since that time.  David and Heiko reviewed these last outstanding patches and agreed to clean them up and rebase on master to complete these patches
+  * One bug is discovered and will be fixed before sent to the ML
+  * Considered if callers of the argv_*() functions should be enforced to provide a gc_arena.  Decided such a change would be quite intrusive and not providing any clear gains.  The argv_*() functions already have an internal gc_arena which is used for the argv arrays of string pointers and is handled properly there.  Where memory is allocated by argv_*() functions to be returned to the calling function, a gc_arena pointer is already provided in that call; that allocation happens in the gc_arena owned by the caller.  This provides a clear separation between internal processing and callers.
+  * Will also try to add a bit more code comments to ensure the code is easier to understand in the future