Changes between Version 9 and Version 10 of FRP


Ignore:
Timestamp:
07/23/10 09:02:16 (14 years ago)
Author:
David Sommerseth
Comment:

Corrected the code wise changes according to the new FRP process.

Legend:

Unmodified
Added
Removed
Modified

  • FRP

    v9 v10  
    4040
    4141== First phase: Enable the feature on request ==
    42 
     42 * Remove the feature by using #ifdef's wherever this feature is called or executed in the source code
     43    * The #ifdef name should start with DEPRECATED_ and then a sensible name for the feature
     44    * Add a warning (using #warning statements) for compile time warnings when the feature is enabled.
     45    * Add log messages (using msg()) whenever this feature is called.
     46     * Make sure that the logging will not be too extensive and happen too often. It should catch attention, but not flood the log.
     47    * Update deprecated.c and add an appropriate warning, inside a #ifdef block for the feature going through the FRP.
    4348 * Update configure.ac
    44   * Rename argument from '''--disable-depr-*''' to '''--enable-depr-*'''
    45   * Change default value from "yes" to "no"
     49    * Locate the section for deprecated features, (search for "Deprecated features")
     50    * Add a new configure argument to enable this feature.  The feature should be disabled by default. The argument should start with --enable-depr- and then a sensible and descriptive feature name.
    4651 * Test the change by compiling and smoke testing OpenVPN.
    4752  * When the feature is disabled (the default)
    … …  
    5560   * Verify that the feature indeed still works
    5661 * Commit the patch(es) and submit them to the openvpn-devel mailinglist.  The subject must start with '''[PATCH]''' followed by '''FRP2: '''
    57   * Example: [PATCH] FRP2: Deprecating feature X by default
     62  * Example: [PATCH] FRP1: Deprecating feature X by default
    5863
    5964== Second phase: Complete removal of the feature ==
    … …  
    6873  * Verify that the feature really is removed when running OpenVPN and that it behaves as expected
    6974 * Commit the patch(es) and submit them to the openvpn-devel mailinglist.  The subject must start with '''[PATCH]''' followed by '''FRP3: '''
    70   * Example: [PATCH] FRP3: Removing deprecated feature X
     75  * Example: [PATCH] FRP2: Removing deprecated feature X
    7176
    7277That's it. Feature is removed.