Changes between Version 1 and Version 2 of ACKSystemReview


Ignore:
Timestamp:
03/27/12 12:33:22 (12 years ago)
Author:
Samuli Seppänen
Comment:

--

Legend:

Unmodified
Added
Removed
Modified

  • ACKSystemReview

    v1 v2  
    3131== Pros ==
    3232
    33 The formal ACK/NACK system was imposed to increase OpenVPN code quality by decreasing the chances of bad code getting into the tree. The mandatory ACK essentially forces peer review. In software engineering jargon, it fulfills the roles of [http://en.wikipedia.org/wiki/Design_rationale rationale management] and [http://en.wikipedia.org/wiki/Static_testing static testing].
     33The formal ACK/NACK system was imposed to increase OpenVPN code quality by decreasing the chances of bad code getting into the tree. The mandatory ACK essentially forces peer review. In software engineering jargon, it fulfills the roles of
     34
     35 * [http://en.wikipedia.org/wiki/Design_rationale Rationale management] (feature-ACKs)
     36 * [http://en.wikipedia.org/wiki/Static_testing Static testing] (code-ACKs)
    3437
    3538== Cons ==
    3639
    37 By it's nature, requiring an ACK slows down development.
     40By it's nature, requiring an ACK slows down flow of code from contributors to the "master" development tree.