Assert at swiching remotes

[stipa]

Prerequisites

• config has two remotes:

 remote google.com 1194
 remote vpnhost.com 1194

• management interface enabled (could be probably reproduced without it)

Steps to reproduce

• run client
• say "hold release"
• say "remote ACCEPT" for a google.com remote
• wait for connection establishment to fail in 60 secs
• say "remote ACCEPT" for a google.com remote
• boom!

Fri Nov 13 14:03:45 2015 us=553767 MANAGEMENT: CMD 'hold release'
Fri Nov 13 14:04:04 2015 us=50234 MANAGEMENT: CMD 'remote SKIP'
Fri Nov 13 14:04:05 2015 us=51525 MANAGEMENT: Client disconnected
Fri Nov 13 14:04:05 2015 us=51562 Assertion failed at init.c:347
Fri Nov 13 14:04:05 2015 us=51570 Exiting due to fatal error

[stipa]

Correction: last two steps are:

• say "remote SKIP" for a google.com remote
• boom!

[stipa]

Seems that we're missing this call:

clear_remote_addrlist (&c->c1.link_socket_addr, !c->options.resolve_in_advance);

Which can be added, for example, instead of those asserts.

[Gert Döring]

Arne, I the remote_addrlist stuff smells like "your code" - could you look into this?

[plaisthos]

Can you post your whole config? The code looks like you also need persist-remote-ip enabled

[plaisthos]

@stipa I am not sure. I think if these assert fail there has been some cleanup missing.

[Gert Döring]

commit 3ad86c2534a92af137809b6d446d570193e6d01f (master)
commit 6554025a422d3d7e5465bcbfad34fa3e196b53b0 (release/2.5)
commit 7fdcd286a15fb4f64e979c4fdbf52223d4bdede0 (release/2.4)
Author: Vladislav Grishenko
Date: Wed Sep 16 19:17:55 2020 +0500

Fix fatal error at switching remotes (#629)

Thanks!