Changes between Initial Version and Version 1 of Ticket #402, comment 3


Ignore:
Timestamp:
05/25/14 13:21:36 (8 years ago)
Author:
Steffan Karger
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #402, comment 3

    initial v1  
    55From what I see in the git history, it seems that the original author of this code was a bit too helpful for administrators, automatically uppercasing for 'CN', 'OU', etc. Then someone else came along and added extended attribute matching, fixing the upper casing for his addition with the strncmp on 'ext:'.
    66
    7 So, I think the only sensible thing to do is to remove the upper casing from options.c, and match on both the upper cased and normal string in {{{backend_x509_get_username()}}}. Is suggest issuing a deprecation warning when the upper casing was needed, and remove it all together in the future.
     7So, I think the only sensible thing to do is to remove the upper casing from options.c, and match on both the upper cased and normal string in {{{backend_x509_get_username()}}}. I suggest issuing a deprecation warning when the upper casing was needed, and remove it all together in the future.